Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42794 )
Change subject: crossgcc: Allow GCC to get asan shadow offset at runtime ......................................................................
Patch Set 18:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@11 PS17, Line 11: ,
Not needed.
Done
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@11 PS17, Line 11: at each stage
By "thus" a few words earlier you already mean "multiple stages". […]
Done
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@16 PS17, Line 16: a callback function
Maybe better "... […]
Done
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@26 PS17, Line 26: the build fails
"the build will fail. […]
Done
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@34 PS17, Line 34: ,
Not needed here.
Done
-
Harshit Sharma (Code Review)