HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60715 )
Change subject: [WIP]src: Remove unused <symbols.h> ......................................................................
[WIP]src: Remove unused <symbols.h>
Found using: diff <(git grep -l '#include <symbols.h>' -- src/) <(git grep -l 'REGION_SIZE|DECLARE_REGION|DECLARE_OPTIONAL_REGION|preram_symbols_available|_dram' -- src/) |grep "<"
Change-Id: Icc8c252255b941a7c91346628d02d697bc510981 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm/armv7/mmu.c M src/arch/arm64/armv8/mmu.c M src/arch/x86/boot.c M src/cpu/x86/lapic/lapic_cpu_init.c M src/cpu/x86/mp_init.c M src/drivers/spi/cbfs_spi.c M src/lib/asan.c M src/lib/decompressor.c M src/lib/fmap.c M src/lib/metadata_hash.c M src/lib/prog_loaders.c M src/lib/ramdetect.c M src/lib/selfboot.c M src/mainboard/emulation/qemu-riscv/rom_media.c M src/mainboard/google/gale/bootblock.c M src/mainboard/google/storm/bootblock.c M src/mainboard/sifive/hifive-unleashed/media.c M src/mainboard/ti/beaglebone/sd_media.c M src/security/tpm/tspi/log.c M src/soc/amd/picasso/bootblock.c M src/soc/cavium/cn81xx/soc.c M src/soc/mediatek/common/i2c.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra210/romstage.c M src/soc/nvidia/tegra210/spi.c M src/soc/qualcomm/common/qspi.c M src/soc/qualcomm/sc7180/display/dsi.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5420/spi.c M src/soc/ti/am335x/header.c 30 files changed, 1 insertion(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/60715/1
diff --git a/src/arch/arm/armv7/mmu.c b/src/arch/arm/armv7/mmu.c index 66ce533..025d297 100644 --- a/src/arch/arm/armv7/mmu.c +++ b/src/arch/arm/armv7/mmu.c @@ -3,10 +3,7 @@ #include <assert.h> #include <commonlib/helpers.h> #include <stdint.h> -#include <symbols.h> - #include <console/console.h> - #include <arch/cache.h>
#if CONFIG(ARM_LPAE) diff --git a/src/arch/arm64/armv8/mmu.c b/src/arch/arm64/armv8/mmu.c index 72e5cca..0c55227 100644 --- a/src/arch/arm64/armv8/mmu.c +++ b/src/arch/arm64/armv8/mmu.c @@ -3,8 +3,6 @@ #include <assert.h> #include <stdint.h> #include <string.h> -#include <symbols.h> - #include <console/console.h> #include <arch/mmu.h> #include <arch/lib_helpers.h> diff --git a/src/arch/x86/boot.c b/src/arch/x86/boot.c index c50ec0e..1484727 100644 --- a/src/arch/x86/boot.c +++ b/src/arch/x86/boot.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <program_loading.h> #include <ip_checksum.h> -#include <symbols.h> #include <assert.h>
int payload_arch_usable_ram_quirk(uint64_t start, uint64_t size) diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index c35888a..e3cbcfb 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -8,7 +8,6 @@ #include <delay.h> #include <lib.h> #include <string.h> -#include <symbols.h> #include <console/console.h> #include <device/device.h> #include <device/path.h> diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index acbe579..f81d0da 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -20,7 +20,6 @@ #include <device/path.h> #include <smp/atomic.h> #include <smp/spinlock.h> -#include <symbols.h> #include <timer.h> #include <thread.h> #include <types.h> diff --git a/src/drivers/spi/cbfs_spi.c b/src/drivers/spi/cbfs_spi.c index 7e648a3..f1843bd 100644 --- a/src/drivers/spi/cbfs_spi.c +++ b/src/drivers/spi/cbfs_spi.c @@ -10,7 +10,6 @@ #include <cbfs.h> #include <console/console.h> #include <spi_flash.h> -#include <symbols.h> #include <cbmem.h> #include <stdint.h> #include <timer.h> diff --git a/src/lib/asan.c b/src/lib/asan.c index 9493b3b..6dc8c9f 100644 --- a/src/lib/asan.c +++ b/src/lib/asan.c @@ -9,7 +9,6 @@ */
#include <console/console.h> -#include <symbols.h> #include <assert.h> #include <arch/symbols.h> #include <asan.h> diff --git a/src/lib/decompressor.c b/src/lib/decompressor.c index 1d160e0..f08a08c 100644 --- a/src/lib/decompressor.c +++ b/src/lib/decompressor.c @@ -5,7 +5,6 @@ #include <delay.h> #include <metadata_hash.h> #include <program_loading.h> -#include <symbols.h> #include <timestamp.h>
extern u8 compressed_bootblock[]; diff --git a/src/lib/fmap.c b/src/lib/fmap.c index 6ff8431..8ae8308 100644 --- a/src/lib/fmap.c +++ b/src/lib/fmap.c @@ -7,7 +7,6 @@ #include <metadata_hash.h> #include <stddef.h> #include <string.h> -#include <symbols.h> #include <endian.h>
#include "fmap_config.h" diff --git a/src/lib/metadata_hash.c b/src/lib/metadata_hash.c index e10f6ff..675e3cd 100644 --- a/src/lib/metadata_hash.c +++ b/src/lib/metadata_hash.c @@ -2,7 +2,6 @@
#include <assert.h> #include <metadata_hash.h> -#include <symbols.h>
#if !CONFIG(COMPRESS_BOOTBLOCK) || ENV_DECOMPRESSOR __attribute__((used, section(".metadata_hash_anchor"))) diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c index 878f729e..e64400b 100644 --- a/src/lib/prog_loaders.c +++ b/src/lib/prog_loaders.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
- #include <stdlib.h> #include <cbfs.h> #include <cbmem.h> @@ -12,7 +11,6 @@ #include <reset.h> #include <rmodule.h> #include <stage_cache.h> -#include <symbols.h> #include <thread.h> #include <timestamp.h> #include <security/vboot/vboot_common.h> diff --git a/src/lib/ramdetect.c b/src/lib/ramdetect.c index 328ca07..5ddacb1 100644 --- a/src/lib/ramdetect.c +++ b/src/lib/ramdetect.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <types.h> -#include <symbols.h> #include <device/mmio.h> #include <ramdetect.h> #include <console/console.h> diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c index f1c0b97..ed5be00 100644 --- a/src/lib/selfboot.c +++ b/src/lib/selfboot.c @@ -6,7 +6,6 @@ #include <stdint.h> #include <stdlib.h> #include <string.h> -#include <symbols.h> #include <cbfs.h> #include <lib.h> #include <bootmem.h> diff --git a/src/mainboard/emulation/qemu-riscv/rom_media.c b/src/mainboard/emulation/qemu-riscv/rom_media.c index 15989f2..b3ee0b4 100644 --- a/src/mainboard/emulation/qemu-riscv/rom_media.c +++ b/src/mainboard/emulation/qemu-riscv/rom_media.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <boot_device.h> -#include <symbols.h>
/* This assumes that the CBFS resides at start of dram, which is true for the * default configuration. */ diff --git a/src/mainboard/google/gale/bootblock.c b/src/mainboard/google/gale/bootblock.c index 343fe65..109ff2b 100644 --- a/src/mainboard/google/gale/bootblock.c +++ b/src/mainboard/google/gale/bootblock.c @@ -2,7 +2,6 @@
#include <bootblock_common.h> #include <console/console.h> -#include <symbols.h>
#include "mmu.h" #include <soc/usbl_if.h> diff --git a/src/mainboard/google/storm/bootblock.c b/src/mainboard/google/storm/bootblock.c index e7ff6a3..852acfe 100644 --- a/src/mainboard/google/storm/bootblock.c +++ b/src/mainboard/google/storm/bootblock.c @@ -2,7 +2,6 @@
#include <bootblock_common.h> #include <console/console.h> -#include <symbols.h>
#include "mmu.h" #include <soc/usbl_if.h> diff --git a/src/mainboard/sifive/hifive-unleashed/media.c b/src/mainboard/sifive/hifive-unleashed/media.c index f3dcf7f..01051be 100644 --- a/src/mainboard/sifive/hifive-unleashed/media.c +++ b/src/mainboard/sifive/hifive-unleashed/media.c @@ -2,7 +2,6 @@
#include <boot_device.h> #include <cbfs.h> -#include <symbols.h> #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/spi.h> diff --git a/src/mainboard/ti/beaglebone/sd_media.c b/src/mainboard/ti/beaglebone/sd_media.c index f6009be..bbd1719 100644 --- a/src/mainboard/ti/beaglebone/sd_media.c +++ b/src/mainboard/ti/beaglebone/sd_media.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <boot_device.h> -#include <symbols.h> #include <console/console.h> #include <assert.h> #include <commonlib/storage/sd_mmc.h> diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 1d6f9ac..f789009 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -4,7 +4,6 @@ #include <security/tpm/tspi.h> #include <region_file.h> #include <string.h> -#include <symbols.h> #include <cbmem.h> #include <bootstate.h> #include <vb2_sha.h> diff --git a/src/soc/amd/picasso/bootblock.c b/src/soc/amd/picasso/bootblock.c index 7d1f01c..aa251ab 100644 --- a/src/soc/amd/picasso/bootblock.c +++ b/src/soc/amd/picasso/bootblock.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <stdint.h> -#include <symbols.h> #include <amdblocks/cpu.h> #include <amdblocks/reset.h> #include <bootblock_common.h> diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index 368e925..1985321 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -14,7 +14,6 @@ #include <stddef.h> #include <stdlib.h> #include <string.h> -#include <symbols.h> #include <libbdk-boot/bdk-boot.h> #include <soc/ecam0.h> #include <console/uart.h> diff --git a/src/soc/mediatek/common/i2c.c b/src/soc/mediatek/common/i2c.c index c47e08e..b285b86 100644 --- a/src/soc/mediatek/common/i2c.c +++ b/src/soc/mediatek/common/i2c.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <delay.h> #include <timer.h> -#include <symbols.h> #include <device/mmio.h> #include <soc/i2c.h> #include <soc/i2c_common.h> diff --git a/src/soc/nvidia/tegra124/clock.c b/src/soc/nvidia/tegra124/clock.c index a2427fe..fb14c4e 100644 --- a/src/soc/nvidia/tegra124/clock.c +++ b/src/soc/nvidia/tegra124/clock.c @@ -12,7 +12,6 @@ #include <soc/maincpu.h> #include <soc/pmc.h> #include <soc/sysctr.h> -#include <symbols.h>
static struct clk_rst_ctlr *clk_rst = (void *)TEGRA_CLK_RST_BASE; static struct flow_ctlr *flow = (void *)TEGRA_FLOW_BASE; diff --git a/src/soc/nvidia/tegra210/romstage.c b/src/soc/nvidia/tegra210/romstage.c index 4f92c5f..3e807dc 100644 --- a/src/soc/nvidia/tegra210/romstage.c +++ b/src/soc/nvidia/tegra210/romstage.c @@ -14,7 +14,6 @@ #include <soc/sdram_configs.h> #include <soc/romstage.h> #include <soc/nvidia/tegra/apbmisc.h> -#include <symbols.h> #include <vendorcode/google/chromeos/chromeos.h>
void __weak romstage_mainboard_init(void) diff --git a/src/soc/nvidia/tegra210/spi.c b/src/soc/nvidia/tegra210/spi.c index f8db110..ed9e0de 100644 --- a/src/soc/nvidia/tegra210/spi.c +++ b/src/soc/nvidia/tegra210/spi.c @@ -11,7 +11,6 @@ #include <soc/addressmap.h> #include <soc/dma.h> #include <soc/spi.h> -#include <symbols.h> #include <types.h>
#if defined(CONFIG_DEBUG_SPI) && CONFIG_DEBUG_SPI diff --git a/src/soc/qualcomm/common/qspi.c b/src/soc/qualcomm/common/qspi.c index b6d2b2d..254481d 100644 --- a/src/soc/qualcomm/common/qspi.c +++ b/src/soc/qualcomm/common/qspi.c @@ -8,7 +8,6 @@ #include <soc/qspi_common.h> #include <soc/gpio.h> #include <soc/clock.h> -#include <symbols.h> #include <assert.h> #include <gpio.h> #include <string.h> diff --git a/src/soc/qualcomm/sc7180/display/dsi.c b/src/soc/qualcomm/sc7180/display/dsi.c index 15d36ed..25d064f 100644 --- a/src/soc/qualcomm/sc7180/display/dsi.c +++ b/src/soc/qualcomm/sc7180/display/dsi.c @@ -7,7 +7,6 @@ #include <assert.h> #include <edid.h> #include <delay.h> -#include <symbols.h> #include <types.h> #include <string.h> #include <soc/display/mipi_dsi.h> diff --git a/src/soc/samsung/exynos5250/spi.c b/src/soc/samsung/exynos5250/spi.c index c7e0707..2347a66 100644 --- a/src/soc/samsung/exynos5250/spi.c +++ b/src/soc/samsung/exynos5250/spi.c @@ -11,7 +11,6 @@ #include <soc/spi.h> #include <stddef.h> #include <stdint.h> -#include <symbols.h>
#if defined(CONFIG_DEBUG_SPI) && CONFIG_DEBUG_SPI # define DEBUG_SPI(x,...) printk(BIOS_DEBUG, "EXYNOS_SPI: " x) diff --git a/src/soc/samsung/exynos5420/spi.c b/src/soc/samsung/exynos5420/spi.c index 2fe9d5c..336eb1d 100644 --- a/src/soc/samsung/exynos5420/spi.c +++ b/src/soc/samsung/exynos5420/spi.c @@ -10,7 +10,6 @@ #include <stddef.h> #include <stdint.h> #include <string.h> -#include <symbols.h>
#define EXYNOS_SPI_MAX_TRANSFER_BYTES (65535)
diff --git a/src/soc/ti/am335x/header.c b/src/soc/ti/am335x/header.c index 7f42a38..74406d5 100644 --- a/src/soc/ti/am335x/header.c +++ b/src/soc/ti/am335x/header.c @@ -2,7 +2,6 @@
#include <commonlib/bsd/helpers.h> #include <stdint.h> -#include <symbols.h>
#include "header.h"
-
HAOUAS Elyes (Code Review)