Srinidhi N Kaushik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
drivers/intel/gma: Increase vbt_data size
With TGL FSP v3373 onwards vbt binary size changed from 8KiB to 9KiB. Due to which cbfsf_decompression_info check failed when trying to load vbt binary from cbfs because vbt decompressed_size was greater than vbt_data size. This caused Graphics Init and fw creen issues. Increase the vbt_data to 9KiB to accommodate new vbt binary.
BUG=b:170656067 BRANCH=none TEST=build and boot delbin and verify fw screen is loaded
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: If6ffce028f9e8bc14596bbc0a3f1476843a9334e --- M src/drivers/intel/gma/opregion.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/46374/1
diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index 7682af1..8f1d2e6 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -19,7 +19,7 @@ return "vbt.bin"; }
-static char vbt_data[8 * KiB]; +static char vbt_data[9 * KiB]; static size_t vbt_data_sz;
void *locate_vbt(size_t *vbt_size)
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46374
to look at the new patch set (#2).
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
drivers/intel/gma: Increase vbt_data size
With TGL FSP v3373 onwards vbt binary size changed from 8KiB to 9KiB. Due to which cbfsf_decompression_info check failed when trying to load vbt binary from cbfs because vbt decompressed_size was greater than vbt_data size. This caused Graphics init and fw screen issues. Increase the vbt_data to 9KiB to accommodate new vbt binary.
BUG=b:170656067 BRANCH=none TEST=build and boot delbin and verify fw screen is loaded
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: If6ffce028f9e8bc14596bbc0a3f1476843a9334e --- M src/drivers/intel/gma/opregion.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/46374/2
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
Patch Set 2: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
Patch Set 3:
I wonder if it makes sense for this to be a Kconfig option? But I guess 9K isn't that much..
Dossym Nurmukhanov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
Patch Set 3: Code-Review+2
Patch Set 3:
I wonder if it makes sense for this to be a Kconfig option? But I guess 9K isn't that much..
I agree. Created a b/171401992 to follow up. Otherwise, the change LGTM.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
Patch Set 3: Code-Review+2
Patch Set 3: Code-Review+2
Patch Set 3:
I wonder if it makes sense for this to be a Kconfig option? But I guess 9K isn't that much..
I agree. Created a b/171401992 to follow up. Otherwise, the change LGTM.
I concur, it would be nice to specify the maximum size a VBT is supposed to be for each platform, if there's any actual constraint.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
Patch Set 3: Code-Review+2
ya sorry didn't mean to hold this up since it is blocking a platform.
Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size ......................................................................
drivers/intel/gma: Increase vbt_data size
With TGL FSP v3373 onwards vbt binary size changed from 8KiB to 9KiB. Due to which cbfsf_decompression_info check failed when trying to load vbt binary from cbfs because vbt decompressed_size was greater than vbt_data size. This caused Graphics init and fw screen issues. Increase the vbt_data to 9KiB to accommodate new vbt binary.
BUG=b:170656067 BRANCH=none TEST=build and boot delbin and verify fw screen is loaded
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: If6ffce028f9e8bc14596bbc0a3f1476843a9334e Reviewed-on: https://review.coreboot.org/c/coreboot/+/46374 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Dossym Nurmukhanov dossym@google.com Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/drivers/intel/gma/opregion.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Nick Vaccaro: Looks good to me, approved Srinidhi N Kaushik: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Dossym Nurmukhanov: Looks good to me, approved
diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index 7682af1..8f1d2e6 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -19,7 +19,7 @@ return "vbt.bin"; }
-static char vbt_data[8 * KiB]; +static char vbt_data[9 * KiB]; static size_t vbt_data_sz;
void *locate_vbt(size_t *vbt_size)
-
Angel Pons (Code Review) -
Dossym Nurmukhanov (Code Review)
-
Duncan Laurie (Code Review)
-
Nick Vaccaro (Code Review)
-
Srinidhi N Kaushik (Code Review)