Change in coreboot[master]: [WIP] [Don't Merge]: PO Safe Config

List overview All Threads
Download

newer

older

[XS] Change in coreboot[master]:...

Change in coreboot[master]: Move...

Meera Ravindranath (Code Review)

10 Dec 2020 10 Dec '20

7:11 a.m.

Hello Subrata Banik,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48527

to review the following change.

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

[WIP] [Don't Merge]: PO Safe Config

Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/48527/1

diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index a21ca4a..f176785 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -273,7 +273,7 @@ sizeof(config->PcieRpClkReqDetect));

params->PmSupport = 1; - params->Hwp = 1; + params->Hwp = 0; params->Cx = 1; params->PsOnEnable = 1;

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Meera Ravindranath (Code Review)

17 Dec 17 Dec

2:59 p.m.

Hello build bot (Jenkins), Subrata Banik, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48527

to look at the new patch set (#2).

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

[WIP] [Don't Merge]: PO Safe Config

Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/48527/2

Subrata Banik (Code Review)

27 Jan 27 Jan

5:17 a.m.

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48527 )

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

Patch Set 3:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 27 Jan 2021 05:17:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:30 a.m.

Attention is currently required from: Tim Wawrzynczak, Meera Ravindranath. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48527 )

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/alderlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/48527/comment/9c6e9517_2d5e18e3 PS3, Line 118: 0 Instead of setting 0 here as a workaround, can we instead disable RUN_FSP_GOP in config.brya0 until the correct fix is available?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Comment-Date: Wed, 27 Jan 2021 07:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

7:31 a.m.

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Meera Ravindranath. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48527 )

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/alderlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/48527/comment/97822794_fdeb11b2 PS3, Line 118: 0

...

Instead of setting 0 here as a workaround, can we instead disable RUN_FSP_GOP in config. […]

Make it 'select MAINBOARD_NO_FSP_GOP' in brya MB ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Comment-Date: Wed, 27 Jan 2021 07:31:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7:33 a.m.

Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Meera Ravindranath. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48527 )

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/alderlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/48527/comment/79187880_4e9d3a1d PS3, Line 118: 0

...

Make it 'select MAINBOARD_NO_FSP_GOP' in brya MB ?

I think this should be sufficient: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-ov...

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Attention: Subrata Banik subrata.banik@intel.com Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Comment-Date: Wed, 27 Jan 2021 07:33:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Gerrit-MessageType: comment

Subrata Banik (Code Review)

7:36 a.m.

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Meera Ravindranath. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48527 )

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

Patch Set 3:

(1 comment)

File src/soc/intel/alderlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/48527/comment/e85afdb5_56026354 PS3, Line 118: 0

...

I think this should be sufficient: https://chromium-review.googlesource. […]

Sure, make a note might be to remove it as we fix the existing issue

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Comment-Date: Wed, 27 Jan 2021 07:36:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Gerrit-MessageType: comment

Meera Ravindranath (Code Review)

9 Mar 9 Mar

8:32 a.m.

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48527

to look at the new patch set (#5).

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

[WIP] [Don't Merge]: PO Safe Config

Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/48527/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 5 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

6:43 p.m.

Attention is currently required from: Furquan Shaikh, Meera Ravindranath. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48527 )

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5: Is this still needed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 5 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Furquan Shaikh furquan@google.com Gerrit-Attention: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Comment-Date: Tue, 09 Mar 2021 18:43:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

10 Jun 10 Jun

3:14 a.m.

New subject: [XS] Change in coreboot[master]: [WIP] [Don't Merge]: PO Safe Config

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48527?usp=email )

Change subject: [WIP] [Don't Merge]: PO Safe Config ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/48527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cce423de924e7056e88b52a2443c554fd9123ac Gerrit-Change-Number: 48527 Gerrit-PatchSet: 5 Gerrit-Owner: Meera Ravindranath meera.ravindranath@intel.com Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

536

days inactive

1448

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

Furquan Shaikh (Code Review)
Meera Ravindranath (Code Review)
Stefan Reinauer (Code Review)
Subrata Banik (Code Review)
Tim Wawrzynczak (Code Review)