Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37733 )
Change subject: mb/google/beltino: Add VBTs for all variants ......................................................................
mb/google/beltino: Add VBTs for all variants
Add VBTs for beltino variants, extracted from VGA BIOS from stock firmware images using intelvbttool, zero-padded to 0x11ff bytes to make the Intel BMP editor happy. Use a common VBT for all except monroe, since it differs as it has a built-in display (being a Chromebase vs box).
Change-Id: I82afb20a5648695c2cd568384a26839ab28be3da Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/Kconfig A src/mainboard/google/beltino/data.vbt A src/mainboard/google/beltino/variants/monroe/data.vbt 3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/37733/1
diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index 01e0cbf..f50d49c 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -9,6 +9,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM @@ -51,6 +52,11 @@ string default "pci8086,0406.rom"
+# Override the default variant behavior, since the data.vbt is the same +# for all variants except monroe +config INTEL_GMA_VBT_FILE + default "src/mainboard/$(MAINBOARDDIR)/data.vbt" if !BOARD_GOOGLE_MONROE + config MAINBOARD_SMBIOS_MANUFACTURER string default "GOOGLE" diff --git a/src/mainboard/google/beltino/data.vbt b/src/mainboard/google/beltino/data.vbt new file mode 100644 index 0000000..3195b15 --- /dev/null +++ b/src/mainboard/google/beltino/data.vbt Binary files differ diff --git a/src/mainboard/google/beltino/variants/monroe/data.vbt b/src/mainboard/google/beltino/variants/monroe/data.vbt new file mode 100644 index 0000000..84ec2e7 --- /dev/null +++ b/src/mainboard/google/beltino/variants/monroe/data.vbt Binary files differ
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37733 )
Change subject: mb/google/beltino: Add VBTs for all variants ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37733/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37733/1//COMMIT_MSG@13 PS1, Line 13: box Nit: specifying "Chromebox" in full would help make the meaning more explicit
Hello Angel Pons, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37733
to look at the new patch set (#2).
Change subject: mb/google/beltino: Add VBTs for all variants ......................................................................
mb/google/beltino: Add VBTs for all variants
Add VBTs for beltino variants, extracted from VGA BIOS from stock firmware images using intelvbttool, zero-padded to 0x11ff bytes to make the Intel BMP editor happy. Use a common VBT for all except monroe, since it differs as it has a built-in display (being a Chromebase vs Chromebox).
Change-Id: I82afb20a5648695c2cd568384a26839ab28be3da Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/beltino/Kconfig A src/mainboard/google/beltino/data.vbt A src/mainboard/google/beltino/variants/monroe/data.vbt 3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/37733/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37733 )
Change subject: mb/google/beltino: Add VBTs for all variants ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37733/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37733/1//COMMIT_MSG@13 PS1, Line 13: box
Nit: specifying "Chromebox" in full would help make the meaning more explicit
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37733 )
Change subject: mb/google/beltino: Add VBTs for all variants ......................................................................
mb/google/beltino: Add VBTs for all variants
Add VBTs for beltino variants, extracted from VGA BIOS from stock firmware images using intelvbttool, zero-padded to 0x11ff bytes to make the Intel BMP editor happy. Use a common VBT for all except monroe, since it differs as it has a built-in display (being a Chromebase vs Chromebox).
Change-Id: I82afb20a5648695c2cd568384a26839ab28be3da Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37733 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/beltino/Kconfig A src/mainboard/google/beltino/data.vbt A src/mainboard/google/beltino/variants/monroe/data.vbt 3 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index 01e0cbf..f50d49c 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -9,6 +9,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM @@ -51,6 +52,11 @@ string default "pci8086,0406.rom"
+# Override the default variant behavior, since the data.vbt is the same +# for all variants except monroe +config INTEL_GMA_VBT_FILE + default "src/mainboard/$(MAINBOARDDIR)/data.vbt" if !BOARD_GOOGLE_MONROE + config MAINBOARD_SMBIOS_MANUFACTURER string default "GOOGLE" diff --git a/src/mainboard/google/beltino/data.vbt b/src/mainboard/google/beltino/data.vbt new file mode 100644 index 0000000..3195b15 --- /dev/null +++ b/src/mainboard/google/beltino/data.vbt Binary files differ diff --git a/src/mainboard/google/beltino/variants/monroe/data.vbt b/src/mainboard/google/beltino/variants/monroe/data.vbt new file mode 100644 index 0000000..84ec2e7 --- /dev/null +++ b/src/mainboard/google/beltino/variants/monroe/data.vbt Binary files differ
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)