Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 )
Change subject: ec/lenovo/h8/acpi: fix wrong calculation
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52144/comment/bde8a745_ad99ad8f
PS2, Line 8:
It’d be great, if you elaborated a bit.
Done
https://review.coreboot.org/c/coreboot/+/52144/comment/725ef869_6b58e179
PS2, Line 9: Fixes: commit 81d55cf6d62ac710df030fc02dd3ca00f3d80405
Please use the common style referencing the commit (also known from the Linux kernel).
well, git log doesn't really show a common style \o/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52144
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701
Gerrit-Change-Number: 52144
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 08 Apr 2021 21:51:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment
Michael Niewöhner (Code Review)