Attention is currently required from: Arthur Heymans, Hsuan Ting Chen, Kapil Porwal, Martin L Roth, Martin Roth, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79056?usp=email )
Change subject: tests/lib: Skip ux_locales-test for !VBOOT platforms
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This will just always skip the tests, then we might as well not have them. I think the better option would be to just enable CONFIG_VBOOT in this test (i.e. add `ux_locales-test-config += CONFIG_VBOOT=1` to `tests/lib/Makefile.inc`)?
(Also, in general please always try to CC the original author if they're still available when patching someone else's code.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79056?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2828eb062e2b601e073e7dab9aef7316fc6ba2cd
Gerrit-Change-Number: 79056
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 01:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment