Change in coreboot[master]: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42797 )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment ......................................................................
sb/intel/ibexpeak/smihandler: Comment out unused variable assignment
Fix the scan-build warning below:
CC smm/southbridge/intel/ibexpeak/smihandler.o src/southbridge/intel/ibexpeak/smihandler.c:135:4: warning: Value stored to 'data' is never read data &= mask; ^ ~~~~ 1 warning generated.
Change-Id: I62060aacfec72a7066ee8c6464231c2ad5203a2a Found-by: scan-build (clang-tools-9 1:9.0.1-12) Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/southbridge/intel/ibexpeak/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/42797/1
diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c index a881f33..861d18e 100644 --- a/src/southbridge/intel/ibexpeak/smihandler.c +++ b/src/southbridge/intel/ibexpeak/smihandler.c @@ -132,7 +132,7 @@ if (!(trap_cycle & (1 << 24))) { // It's a write printk(BIOS_DEBUG, "SMI1 command\n"); data = RCBA32(0x1e18); - data &= mask; + // data &= mask; // if (smi1) // southbridge_smi_command(data); // return;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42797 )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... PS1, Line 135: // data &= mask; : // if (smi1) : // southbridge_smi_command(data); : // return; How about dropping everything instead?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42797 )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... PS1, Line 135: // data &= mask; : // if (smi1) : // southbridge_smi_command(data); : // return;
How about dropping everything instead?
I do not know. I can do that in a follow-up. Then whoever looks at the code, and wants to revert it, can resurrect the correct code.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42797 )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/smihandler.c:
https://review.coreboot.org/c/coreboot/+/42797/1/src/southbridge/intel/ibexp... PS1, Line 135: // data &= mask; : // if (smi1) : // southbridge_smi_command(data); : // return;
I do not know. I can do that in a follow-up. […]
I did CB:43269
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42797?usp=email )
Change subject: sb/intel/ibexpeak/smihandler: Comment out unused variable assignment ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
Martin L Roth (Code Review)
-
Paul Menzel (Code Review)