Attention is currently required from: Nico Huber, Martin Roth, Tim Wawrzynczak, Sugnan Prabhu S, Subrata Banik, Angel Pons, Balaji Manigandan, Aamir Bohra.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49479 )
Change subject: mb/intel/shadowmountain: Add bootblock and verstage code
......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS6:
Selection of CHROMEOS seems unwarranted and should be explained in detail.
I have removed the selection and will handle it from the config.<board>.
File src/mainboard/intel/shadowmountain/Kconfig:
https://review.coreboot.org/c/coreboot/+/49479/comment/c682f53b_91413718
PS5, Line 24: default y
If that is true, this is the first board that requires CHROMEOS […]
I have removed the selection and will handle it from the config.<board> [https://review.coreboot.org/c/coreboot/+/50118]
File src/mainboard/intel/shadowmountain/Kconfig:
https://review.coreboot.org/c/coreboot/+/49479/comment/c575c9a1_5f7a974c
PS6, Line 6: select CHROMEOS
@Sowmya, you don't need to select this by default.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f805baf42203306ff10e91a258d9117dd986c4a
Gerrit-Change-Number: 49479
Gerrit-PatchSet: 7
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Fri, 05 Feb 2021 04:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: V Sowmya
v.sowmya@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment