Attention is currently required from: Martin Roth, Angel Pons, Arthur Heymans, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51340 )
Change subject: mainboard: Drop invalid `VGA_BIOS_FILE` defaults
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS2:
As long as the config isn't enabled by default (Which it obviously isn't because if it were, the board wouldn't pass on jenkins), I don't see an issue here. It's not hurting anything, it's off in a mainboard directory, not common code, so just ignore it.
It's 40+ more places to maintain if something changes. Also, it encourages
people to put files in places that Git doesn't ignore. Why is Google not
using the site-local/ mechanism? I know, it's only been 10 years; hard to
keep up with all the new technology.
There's also the question why the upstream community should maintain things
that only work in combination with downstream additions, your overlays for
instance.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2
Gerrit-Change-Number: 51340
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sun, 05 Sep 2021 17:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment