[M] Change in coreboot[main]: drivers/intel/gma/opregion: Use CBFS cache to load VBT

[Julius Werner (Code Review)]

Attention is currently required from: Arthur Heymans, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Nico Huber, Tarun.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77886?usp=email )

Change subject: drivers/intel/gma/opregion: Use CBFS cache to load VBT
......................................................................

Patch Set 33: Code-Review+2

(1 comment)

File src/drivers/intel/gma/opregion.c:

https://review.coreboot.org/c/coreboot/+/77886/comment/3a6dffda_c5f8f029 :
PS4, Line 27: cbfs_map
> According to cscope, `local_vbt()` is called before but also after FSP-S (during GMA initialization) […]

Yes, it's pretty common practice to leak when necessary (e.g. if the file needs to stay around for later like in this case). It's just a memory allocator, and things like this are exactly what it was meant for (as opposed to needing to manually create scratch buffer arrays everywhere like this file did before).