[M] Change in coreboot[master]: soc/amd/common/block/data_fabric: Use register bitslice structs - coreboot-gerrit

3 Nov 2022


      Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69073 )
Change subject: soc/amd/common/block/data_fabric: Use register bitslice structs
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/data_fabric/data_fabric_helper.c:
https://review.coreboot.org/c/coreboot/+/69073/comment/2e09cbe9_51fae5b8 
PS1, Line 17: 	ficaa.reg_num = reg >> 2;
...
not sure if this is obvious from the code, but maybe add a comment here that this is the number of t […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69073
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5566f7af6cf5444fc8c627e004dd08185468c77
Gerrit-Change-Number: 69073
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 03 Nov 2022 17:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment