HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39071 )
Change subject: include/arch/cpu.h: Remove old refrence to ROMCC ......................................................................
include/arch/cpu.h: Remove old refrence to ROMCC
Change-Id: I17d13c53baf16f58e6e2ba45f439c36f7ba28690 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/include/arch/cpu.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39071/1
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index c8cf8c7..59eb9ad 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -261,7 +261,6 @@ return ci; }
-/* romcc is segfaulting in some cases. */ struct cpuinfo_x86 { uint8_t x86; /* CPU family */ uint8_t x86_vendor; /* CPU vendor */ @@ -281,7 +280,6 @@
}
-/* romcc does not understand regparm. */ #define asmlinkage __attribute__((regparm(0)))
/*
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39071 )
Change subject: include/arch/cpu.h: Remove old refrence to ROMCC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39071/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39071/1//COMMIT_MSG@7 PS1, Line 7: refrence typo! ref*e*rence
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39071 )
Change subject: include/arch/cpu.h: Remove old refrence to ROMCC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39071/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39071/1//COMMIT_MSG@7 PS1, Line 7: refrence
typo! ref*e*rence
Oops :)
Thx
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39071
to look at the new patch set (#2).
Change subject: include/arch/cpu.h: Remove old reference to ROMCC ......................................................................
include/arch/cpu.h: Remove old reference to ROMCC
Change-Id: I17d13c53baf16f58e6e2ba45f439c36f7ba28690 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/include/arch/cpu.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39071/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39071 )
Change subject: include/arch/cpu.h: Remove old reference to ROMCC ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39071 )
Change subject: include/arch/cpu.h: Remove old reference to ROMCC ......................................................................
include/arch/cpu.h: Remove old reference to ROMCC
Change-Id: I17d13c53baf16f58e6e2ba45f439c36f7ba28690 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/39071 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/include/arch/cpu.h 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index c8cf8c7..59eb9ad 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -261,7 +261,6 @@ return ci; }
-/* romcc is segfaulting in some cases. */ struct cpuinfo_x86 { uint8_t x86; /* CPU family */ uint8_t x86_vendor; /* CPU vendor */ @@ -281,7 +280,6 @@
}
-/* romcc does not understand regparm. */ #define asmlinkage __attribute__((regparm(0)))
/*
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39071 )
Change subject: include/arch/cpu.h: Remove old reference to ROMCC ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/809 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/808 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/807
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)