[L] Change in coreboot[main]: [Squash]: Add ACPI BDAT support

[Arthur Heymans (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Chen, Gang C, Cliff Huang, Gaggery Tsai, Jamie Ryu, Jérémy Compostella, Kane Chen, Karthik Ramasubramanian, Krishna P Bhat D, Lance Zhao, Pratikkumar V Prajapati, Ravishankar Sarawadi, Ronak Kanabar, Subrata Banik, Tim Wawrzynczak, V Sowmya, Wonkyu Kim.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77255?usp=email )

Change subject: [Squash]: Add ACPI BDAT support
......................................................................

Patch Set 15: Code-Review+1

(4 comments)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/77255/comment/474b03fb_be7fb726 :
PS15, Line 1108: /* Calculate checksum */
               : 	header->checksum = acpi_checksum((void *)bdat, header->length);
remove

File src/soc/intel/common/block/acpi/acpi_bdat.c:

https://review.coreboot.org/c/coreboot/+/77255/comment/792c5e56_7741ff16 :
PS15, Line 23: static void print_guid(EFI_GUID *guid)
             : {
             : 	int i;
             : 	if (guid != NULL) {
             : 		printk(BIOS_DEBUG, "GUID = ");
             : 		printk(BIOS_DEBUG, "0x%08x-", guid->Data1);
             : 		printk(BIOS_DEBUG, "0x%04x-", guid->Data2);
             : 		printk(BIOS_DEBUG, "0x%04x-", guid->Data3);
             : 		for (i = 0; i < GUID_TAIL_BYTES; i++) {
             : 			printk(BIOS_DEBUG, "0x%02x", guid->Data4[i]);
             : 			if (i != (GUID_TAIL_BYTES-1))
             : 				printk(BIOS_DEBUG, "-");
             : 		}
             : 		printk(BIOS_DEBUG, "\n");
             : 	}
             : }
this is reimplemented a lot. Can it be added to common code somewhere or reuse existing code.

https://review.coreboot.org/c/coreboot/+/77255/comment/0f628fad_f843c6e8 :
PS15, Line 40: get_crc16
Use CRC marcro?

https://review.coreboot.org/c/coreboot/+/77255/comment/2db46581_fa7eaf54 :
PS15, Line 86: if (guid != NULL)
reduce indentation:

if (guid == NULL) continue; ...