Change in coreboot[master]: superio/aspeed/common: Add early configure functions - coreboot-gerrit

27 Apr 2020


      Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40483 )
Change subject: superio/aspeed/common: Add early configure functions
......................................................................
Patch Set 5:
(1 comment)
...
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/40483/3/src/superio/aspeed/common/a... 
File src/superio/aspeed/common/aspeed.h:
https://review.coreboot.org/c/coreboot/+/40483/3/src/superio/aspeed/common/a... 
PS3, Line 10: #define ASPEED_MEM_BASE1 0x1E6E0000
...
Great, please add that as comment so once whis superio driver is used for different models it will b […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib59c29a042b2c7bf196b8a5bd5218704d8075855
Gerrit-Change-Number: 40483
Gerrit-PatchSet: 5
Gerrit-Owner: Bryant Ou bryant.ou.q@gmail.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Ryback Hung ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 09:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Comment-In-Reply-To: Bryant Ou bryant.ou.q@gmail.com
Gerrit-MessageType: comment