Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54132 )
Change subject: drivers/acpi: Add device tree driver to generate thermal zone ......................................................................
Patch Set 1:
(2 comments)
File src/drivers/acpi/thermal_zone/chip.h:
https://review.coreboot.org/c/coreboot/+/54132/comment/62dbf5c1_41b4649a PS1, Line 51: acpigen_write_thermal_zone_get_temperature
that is one heck of a name there 😊 suggestion: `mainboard_acpigen_write_tz_get_temp` ?
Having had a bad nights sleep ;)
I was thinking acpigen_write_TMP to match the naming or other acpigen methods.
Thoughts?
https://review.coreboot.org/c/coreboot/+/54132/comment/164168fa_8b856b53 PS1, Line 52: drivers_acpi_thermal_zone_config
I wonder if it's always necessary to pass this whole structure to this...
I was tempted to pass the device instead, but then the method would need to do a config_of to pull out the sensor_id. Though we need the device anyway to look up the EC. I'll refactor a bit.