Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )
Change subject: superio: Add ASpeed AST2400 ......................................................................
Patch Set 20:
(5 comments)
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/Makefile.inc File src/superio/aspeed/Makefile.inc:
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/Makefile.inc@18 PS20, Line 18: bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += common/early_serial.c .. COMMON_PRE_RAM
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/Makefile.inc@21 PS20, Line 21: romstage-$(CONFIG_SUPERIO_ASPEED_COMMON_ROMSTAGE) += common/early_serial.c ..COMMON_PRE_RAM
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/ast2400/ast2400.... File src/superio/aspeed/ast2400/ast2400.h:
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/ast2400/ast2400.... PS20, Line 31: void pnp_enter_ext_func_mode(pnp_devfn_t dev); <device/pnp_type.h>
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/ast2400/ast2400.... PS20, Line 34: void aspeed2400_enable_serial(u16 port, u16 device, u16 iobase); <stdint.h> ?
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/common/early_ser... File src/superio/aspeed/common/early_serial.c:
https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/common/early_ser... PS20, Line 50: outb(ASPEED_ENTRY_KEY, port); You want <arch/io.h> for this.
-
Kyösti Mälkki (Code Review)