Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49745 )
Change subject: nb/intel/i945: Drop casts from DEFAULT_{MCH,DMI}BAR ......................................................................
nb/intel/i945: Drop casts from DEFAULT_{MCH,DMI}BAR
They aren't necessary. Removing them changes the binary because the corresponding access macros no longer perform pointer arithmetics.
Change-Id: I9723a00b58ee35befdce6a3a51aa2b1fce8efa80 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49745 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/i945/memmap.h 1 file changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/memmap.h b/src/northbridge/intel/i945/memmap.h index a890445..fcda447 100644 --- a/src/northbridge/intel/i945/memmap.h +++ b/src/northbridge/intel/i945/memmap.h @@ -5,13 +5,8 @@
/* Northbridge BARs */ #define DEFAULT_X60BAR 0xfed13000 -#ifndef __ACPI__ -#define DEFAULT_MCHBAR ((u8 *)0xfed14000) /* 16 KB */ -#define DEFAULT_DMIBAR ((u8 *)0xfed18000) /* 4 KB */ -#else #define DEFAULT_MCHBAR 0xfed14000 /* 16 KB */ #define DEFAULT_DMIBAR 0xfed18000 /* 4 KB */ -#endif #define DEFAULT_EPBAR 0xfed19000 /* 4 KB */
#endif