HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37519 )
Change subject: southbridge: Remove unused '#include <device/pci.h>' ......................................................................
southbridge: Remove unused '#include <device/pci.h>'
Change-Id: I8eb2eee5addcf7247422aae626b19077a0533280 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/hudson.c M src/southbridge/amd/agesa/hudson/spi.c M src/southbridge/amd/cimx/sb800/fan.c M src/southbridge/amd/cimx/sb800/spi.c M src/southbridge/amd/pi/hudson/hudson.c M src/southbridge/intel/bd82x6x/elog.c M src/southbridge/intel/bd82x6x/pch.c M src/southbridge/intel/common/gpio.c M src/southbridge/intel/common/pciehp.c M src/southbridge/intel/common/pmbase.c M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/common/smi.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/common/watchdog.c M src/southbridge/intel/i82371eb/fadt.c M src/southbridge/intel/i82801dx/i82801dx.c M src/southbridge/intel/i82801dx/smi.c M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801ix/i82801ix.c M src/southbridge/intel/i82801ix/smi.c M src/southbridge/intel/i82801jx/i82801jx.c M src/southbridge/intel/ibexpeak/madt.c M src/southbridge/intel/ibexpeak/pch.c M src/southbridge/intel/lynxpoint/elog.c M src/southbridge/intel/lynxpoint/lp_gpio.c M src/southbridge/intel/lynxpoint/pch.c M src/southbridge/intel/lynxpoint/pmutil.c M src/southbridge/intel/lynxpoint/rcba.c M src/southbridge/intel/lynxpoint/smi.c 29 files changed, 0 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/37519/1
diff --git a/src/southbridge/amd/agesa/hudson/hudson.c b/src/southbridge/amd/agesa/hudson/hudson.c index d586d33..f8a1151 100644 --- a/src/southbridge/amd/agesa/hudson/hudson.c +++ b/src/southbridge/amd/agesa/hudson/hudson.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <device/mmio.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/amd/agesa/hudson/spi.c b/src/southbridge/amd/agesa/hudson/spi.c index 9656027..53644b5 100644 --- a/src/southbridge/amd/agesa/hudson/spi.c +++ b/src/southbridge/amd/agesa/hudson/spi.c @@ -18,7 +18,6 @@ #include <spi_flash.h> #include <spi-generic.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h>
#include <Proc/Fch/FchPlatform.h> diff --git a/src/southbridge/amd/cimx/sb800/fan.c b/src/southbridge/amd/cimx/sb800/fan.c index 42c13d7..c702e99 100644 --- a/src/southbridge/amd/cimx/sb800/fan.c +++ b/src/southbridge/amd/cimx/sb800/fan.c @@ -15,7 +15,6 @@
#include <amdblocks/acpimmio.h> #include <device/device.h> -#include <device/pci.h> /* device_operations */ #include <device/pci_ops.h> #include "SBPLATFORM.h" #include "sb_cimx.h" diff --git a/src/southbridge/amd/cimx/sb800/spi.c b/src/southbridge/amd/cimx/sb800/spi.c index fcb4fa1..2256221 100644 --- a/src/southbridge/amd/cimx/sb800/spi.c +++ b/src/southbridge/amd/cimx/sb800/spi.c @@ -18,7 +18,6 @@ #include <spi_flash.h> #include <spi-generic.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <types.h>
diff --git a/src/southbridge/amd/pi/hudson/hudson.c b/src/southbridge/amd/pi/hudson/hudson.c index 51c37a1..db153fd 100644 --- a/src/southbridge/amd/pi/hudson/hudson.c +++ b/src/southbridge/amd/pi/hudson/hudson.c @@ -19,7 +19,6 @@ #include <device/mmio.h> #include <arch/acpi.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/southbridge/intel/bd82x6x/elog.c b/src/southbridge/intel/bd82x6x/elog.c index e96c38d..65cab72 100644 --- a/src/southbridge/intel/bd82x6x/elog.c +++ b/src/southbridge/intel/bd82x6x/elog.c @@ -16,7 +16,6 @@ #include <arch/io.h> #include <arch/acpi.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <stdint.h> #include <elog.h> diff --git a/src/southbridge/intel/bd82x6x/pch.c b/src/southbridge/intel/bd82x6x/pch.c index 5c2b130..3e19d61 100644 --- a/src/southbridge/intel/bd82x6x/pch.c +++ b/src/southbridge/intel/bd82x6x/pch.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <delay.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <device/pci_ops.h> #include <string.h> diff --git a/src/southbridge/intel/common/gpio.c b/src/southbridge/intel/common/gpio.c index 9731d75..19d33ae 100644 --- a/src/southbridge/intel/common/gpio.c +++ b/src/southbridge/intel/common/gpio.c @@ -17,7 +17,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h>
#include "gpio.h"
diff --git a/src/southbridge/intel/common/pciehp.c b/src/southbridge/intel/common/pciehp.c index 8ff41b3..588b565 100644 --- a/src/southbridge/intel/common/pciehp.c +++ b/src/southbridge/intel/common/pciehp.c @@ -18,7 +18,6 @@ #include <arch/acpi.h> #include <arch/acpigen.h> #include <device/device.h> -#include <device/pci.h>
#include "pciehp.h"
diff --git a/src/southbridge/intel/common/pmbase.c b/src/southbridge/intel/common/pmbase.c index ff0410a..5aea7d6 100644 --- a/src/southbridge/intel/common/pmbase.c +++ b/src/southbridge/intel/common/pmbase.c @@ -18,7 +18,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <assert.h> #include <security/vboot/vboot_common.h>
diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c index 366fe08..f2ddeb0 100644 --- a/src/southbridge/intel/common/rcba_pirq.c +++ b/src/southbridge/intel/common/rcba_pirq.c @@ -15,7 +15,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> #include <southbridge/intel/common/rcba.h> diff --git a/src/southbridge/intel/common/smi.c b/src/southbridge/intel/common/smi.c index 1348174..632b393 100644 --- a/src/southbridge/intel/common/smi.c +++ b/src/southbridge/intel/common/smi.c @@ -16,7 +16,6 @@
#include <device/device.h> -#include <device/pci.h> #include <console/console.h> #include <arch/io.h> #include <cpu/x86/cache.h> diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c index cf67817..837d640 100644 --- a/src/southbridge/intel/common/spi.c +++ b/src/southbridge/intel/common/spi.c @@ -28,7 +28,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <spi_flash.h> #include <spi-generic.h>
diff --git a/src/southbridge/intel/common/watchdog.c b/src/southbridge/intel/common/watchdog.c index 2eaedab..cace9d5 100644 --- a/src/southbridge/intel/common/watchdog.c +++ b/src/southbridge/intel/common/watchdog.c @@ -17,7 +17,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <device/pci_ops.h> #include <southbridge/intel/common/pmbase.h> diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c index cbfb0af..2496d19 100644 --- a/src/southbridge/intel/i82371eb/fadt.c +++ b/src/southbridge/intel/i82371eb/fadt.c @@ -20,7 +20,6 @@ #include <string.h> #include <arch/acpi.h> #include <device/device.h> -#include <device/pci.h> #include <version.h>
#include "i82371eb.h" diff --git a/src/southbridge/intel/i82801dx/i82801dx.c b/src/southbridge/intel/i82801dx/i82801dx.c index 765bcb2..759e726 100644 --- a/src/southbridge/intel/i82801dx/i82801dx.c +++ b/src/southbridge/intel/i82801dx/i82801dx.c @@ -15,7 +15,6 @@ */
#include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include "i82801dx.h"
diff --git a/src/southbridge/intel/i82801dx/smi.c b/src/southbridge/intel/i82801dx/smi.c index dc53220..2209292 100644 --- a/src/southbridge/intel/i82801dx/smi.c +++ b/src/southbridge/intel/i82801dx/smi.c @@ -16,7 +16,6 @@
#include <device/device.h> -#include <device/pci.h> #include <console/console.h> #include <arch/acpi.h> #include <arch/io.h> diff --git a/src/southbridge/intel/i82801gx/i82801gx.c b/src/southbridge/intel/i82801gx/i82801gx.c index 6aab741..151a777 100644 --- a/src/southbridge/intel/i82801gx/i82801gx.c +++ b/src/southbridge/intel/i82801gx/i82801gx.c @@ -16,7 +16,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include "i82801gx.h" #include "sata.h" diff --git a/src/southbridge/intel/i82801ix/i82801ix.c b/src/southbridge/intel/i82801ix/i82801ix.c index 753c336a..9686ff8 100644 --- a/src/southbridge/intel/i82801ix/i82801ix.c +++ b/src/southbridge/intel/i82801ix/i82801ix.c @@ -19,7 +19,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <console/console.h> #include "chip.h" #include "i82801ix.h" diff --git a/src/southbridge/intel/i82801ix/smi.c b/src/southbridge/intel/i82801ix/smi.c index 5f73f41..5650c75 100644 --- a/src/southbridge/intel/i82801ix/smi.c +++ b/src/southbridge/intel/i82801ix/smi.c @@ -17,7 +17,6 @@
#include <device/device.h> -#include <device/pci.h> #include <console/console.h> #include <arch/io.h> #include <device/pci_ops.h> diff --git a/src/southbridge/intel/i82801jx/i82801jx.c b/src/southbridge/intel/i82801jx/i82801jx.c index ebd427f..3c6e293 100644 --- a/src/southbridge/intel/i82801jx/i82801jx.c +++ b/src/southbridge/intel/i82801jx/i82801jx.c @@ -19,7 +19,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <console/console.h> #include "chip.h" #include "i82801jx.h" diff --git a/src/southbridge/intel/ibexpeak/madt.c b/src/southbridge/intel/ibexpeak/madt.c index 3676a47..15b9510 100644 --- a/src/southbridge/intel/ibexpeak/madt.c +++ b/src/southbridge/intel/ibexpeak/madt.c @@ -19,7 +19,6 @@ #include <arch/acpi.h> #include <arch/smp/mpspec.h> #include <device/device.h> -#include <device/pci.h>
unsigned long acpi_fill_madt(unsigned long current) { diff --git a/src/southbridge/intel/ibexpeak/pch.c b/src/southbridge/intel/ibexpeak/pch.c index 9148b44..f8bcc10 100644 --- a/src/southbridge/intel/ibexpeak/pch.c +++ b/src/southbridge/intel/ibexpeak/pch.c @@ -18,7 +18,6 @@ #include <console/console.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include "pch.h"
diff --git a/src/southbridge/intel/lynxpoint/elog.c b/src/southbridge/intel/lynxpoint/elog.c index 6f12c70..15f9604 100644 --- a/src/southbridge/intel/lynxpoint/elog.c +++ b/src/southbridge/intel/lynxpoint/elog.c @@ -16,7 +16,6 @@ #include <arch/io.h> #include <arch/acpi.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <stdint.h> #include <elog.h> diff --git a/src/southbridge/intel/lynxpoint/lp_gpio.c b/src/southbridge/intel/lynxpoint/lp_gpio.c index 1919d58..115229f 100644 --- a/src/southbridge/intel/lynxpoint/lp_gpio.c +++ b/src/southbridge/intel/lynxpoint/lp_gpio.c @@ -17,7 +17,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h>
#include "pch.h" #include "lp_gpio.h" diff --git a/src/southbridge/intel/lynxpoint/pch.c b/src/southbridge/intel/lynxpoint/pch.c index cb50c12..cdd2065 100644 --- a/src/southbridge/intel/lynxpoint/pch.c +++ b/src/southbridge/intel/lynxpoint/pch.c @@ -19,7 +19,6 @@ #include <delay.h> #include <device/pci_ops.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include "pch.h"
diff --git a/src/southbridge/intel/lynxpoint/pmutil.c b/src/southbridge/intel/lynxpoint/pmutil.c index cc49477..095fe64 100644 --- a/src/southbridge/intel/lynxpoint/pmutil.c +++ b/src/southbridge/intel/lynxpoint/pmutil.c @@ -21,7 +21,6 @@
#include <arch/io.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_def.h> #include <console/console.h> #include <security/vboot/vbnv.h> diff --git a/src/southbridge/intel/lynxpoint/rcba.c b/src/southbridge/intel/lynxpoint/rcba.c index 57253cb..d843547 100644 --- a/src/southbridge/intel/lynxpoint/rcba.c +++ b/src/southbridge/intel/lynxpoint/rcba.c @@ -15,7 +15,6 @@
#include <device/pci_def.h> #include <device/device.h> -#include <device/pci.h> #include "pch.h"
void pch_config_rcba(const struct rcba_config_instruction *rcba_config) diff --git a/src/southbridge/intel/lynxpoint/smi.c b/src/southbridge/intel/lynxpoint/smi.c index e5c390e..0d6a548 100644 --- a/src/southbridge/intel/lynxpoint/smi.c +++ b/src/southbridge/intel/lynxpoint/smi.c @@ -16,7 +16,6 @@
#include <bootstate.h> #include <device/device.h> -#include <device/pci.h> #include <console/console.h> #include <arch/io.h> #include <cpu/intel/smm_reloc.h>
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37519
to look at the new patch set (#3).
Change subject: southbridge: Remove unused '#include <device/pci.h>' ......................................................................
southbridge: Remove unused '#include <device/pci.h>'
Change-Id: I8eb2eee5addcf7247422aae626b19077a0533280 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/hudson.c M src/southbridge/amd/agesa/hudson/spi.c M src/southbridge/amd/cimx/sb800/fan.c M src/southbridge/amd/cimx/sb800/spi.c M src/southbridge/amd/pi/hudson/hudson.c M src/southbridge/intel/bd82x6x/elog.c M src/southbridge/intel/bd82x6x/pch.c M src/southbridge/intel/common/gpio.c M src/southbridge/intel/common/pciehp.c M src/southbridge/intel/common/pmbase.c M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/common/smi.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/common/watchdog.c M src/southbridge/intel/i82371eb/fadt.c M src/southbridge/intel/i82801dx/i82801dx.c M src/southbridge/intel/i82801dx/smi.c M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801ix/i82801ix.c M src/southbridge/intel/i82801ix/smi.c M src/southbridge/intel/i82801jx/i82801jx.c M src/southbridge/intel/ibexpeak/madt.c M src/southbridge/intel/ibexpeak/pch.c M src/southbridge/intel/lynxpoint/elog.c M src/southbridge/intel/lynxpoint/lp_gpio.c M src/southbridge/intel/lynxpoint/pch.c M src/southbridge/intel/lynxpoint/pmutil.c M src/southbridge/intel/lynxpoint/rcba.c M src/southbridge/intel/lynxpoint/smi.c 29 files changed, 1 insertion(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/37519/3
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37519
to look at the new patch set (#4).
Change subject: southbridge: Remove unused '#include <device/pci.h>' ......................................................................
southbridge: Remove unused '#include <device/pci.h>'
Change-Id: I8eb2eee5addcf7247422aae626b19077a0533280 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/hudson.c M src/southbridge/amd/agesa/hudson/spi.c M src/southbridge/amd/cimx/sb800/fan.c M src/southbridge/amd/cimx/sb800/spi.c M src/southbridge/amd/pi/hudson/hudson.c M src/southbridge/intel/bd82x6x/elog.c M src/southbridge/intel/bd82x6x/pch.c M src/southbridge/intel/common/gpio.c M src/southbridge/intel/common/pciehp.c M src/southbridge/intel/common/pmbase.c M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/common/smi.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/common/watchdog.c M src/southbridge/intel/i82371eb/fadt.c M src/southbridge/intel/i82801dx/i82801dx.c M src/southbridge/intel/i82801dx/smi.c M src/southbridge/intel/i82801gx/i82801gx.c M src/southbridge/intel/i82801ix/i82801ix.c M src/southbridge/intel/i82801ix/smi.c M src/southbridge/intel/i82801jx/i82801jx.c M src/southbridge/intel/ibexpeak/madt.c M src/southbridge/intel/ibexpeak/pch.c M src/southbridge/intel/lynxpoint/elog.c M src/southbridge/intel/lynxpoint/lp_gpio.c M src/southbridge/intel/lynxpoint/pch.c M src/southbridge/intel/lynxpoint/pmutil.c M src/southbridge/intel/lynxpoint/rcba.c M src/southbridge/intel/lynxpoint/smi.c 29 files changed, 0 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/37519/4
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37519 )
Change subject: southbridge: Remove unused '#include <device/pci.h>' ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)