Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74850 )
Change subject: soc/intel/adl: Unhide PMC, IOM ACPI devices from OS ......................................................................
soc/intel/adl: Unhide PMC, IOM ACPI devices from OS
These were hidden because no Windows drivers existed, but now that they do, the ACPI devices need to be visible in order for the drivers to properly attach.
TEST=build google/banshee, boot Windows, verify Windows drivers correctly attach to PCM/IOM devices.
Change-Id: Idbbaee29bffb49059d8450abd09e0c3f7b490fae Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/74850 Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: CoolStar coolstarorganization@gmail.com Reviewed-by: Sean Rhodes sean@starlabs.systems --- M src/soc/intel/alderlake/acpi/tcss.asl M src/soc/intel/alderlake/pmc.c 2 files changed, 24 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified CoolStar: Looks good to me, but someone else must approve Sean Rhodes: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/acpi/tcss.asl b/src/soc/intel/alderlake/acpi/tcss.asl index 5c95997..6f8edda 100644 --- a/src/soc/intel/alderlake/acpi/tcss.asl +++ b/src/soc/intel/alderlake/acpi/tcss.asl @@ -331,8 +331,7 @@ Name (_CRS, ResourceTemplate () { Memory32Fixed (ReadWrite, IOM_BASE_ADDRESS, IOM_BASE_SIZE) }) - /* Hide the device so that Windows does not complain on missing driver */ - Name (_STA, 0xB) + Name (_STA, 0xF) }
/* diff --git a/src/soc/intel/alderlake/pmc.c b/src/soc/intel/alderlake/pmc.c index c28ee2d..c9a089b 100644 --- a/src/soc/intel/alderlake/pmc.c +++ b/src/soc/intel/alderlake/pmc.c @@ -108,8 +108,7 @@
acpigen_write_name_string("_HID", PMC_HID); acpigen_write_name_string("_DDN", "Intel(R) Alder Lake IPC Controller"); - /* Hide the device so that Windows does not complain on missing driver */ - acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON); + acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
/* * Part of the PCH's reserved 32 MB MMIO range (0xFC800000 - 0xFE7FFFFF).