Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45899 )
Change subject: vendorcode/intel/fsp: Add Jasper Lake FSP headers for FSP v2376
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45899/5/src/vendorcode/intel/fsp/fs...
File src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/45899/5/src/vendorcode/intel/fsp/fs...
PS5, Line 2715: Level 1
Are there more levels?
Right now there is only one level. It is kind of place holder here, if in future revisions if FSP teams feels need to break it in some more levels they can add level in same UPD give some more flexibility.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65c03d8eda11664541479983c7be11854410e1c6
Gerrit-Change-Number: 45899
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 07:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment