[M] Change in coreboot[main]: drivers/wifi: Support Bluetooth Regulator Domain Settings - coreboot-gerrit

2 Jul 2024


      Attention is currently required from: Eric Lai, Jérémy Compostella, Subrata Banik, dinesh.sharma@intel.com.
YH Lin has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83200?usp=email )
Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings
......................................................................
Patch Set 9:
(1 comment)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/83200/comment/10bf2db6_59ee03f3?usp... :
PS9, Line 493: bsar
...
Because it can't be NULL as the variable is on the stack.
Hmm. IMHO, checking the null-ness is probably a good idea since the callee won't know how `sar` come from, stack or otherwise?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209
Gerrit-Change-Number: 83200
Gerrit-PatchSet: 9
Gerrit-Owner: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: YH Lin yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: dinesh.sharma@intel.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: dinesh.sharma@intel.com
Gerrit-Comment-Date: Tue, 02 Jul 2024 16:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella jeremy.compostella@intel.com