Change in coreboot[master]: drivers/generic/max98357a: Don't write device if HID is missing

[Raul Rangel (Code Review)]

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42014 )

Change subject: drivers/generic/max98357a: Don't write device if HID is missing
......................................................................

drivers/generic/max98357a: Don't write device if HID is missing

If the device is missing the HID, the code would previously leave an
open scope and device on the stack.

BUG=b:154756391
TEST=Verify stack ACPI stack does not exceed limit on Trembyle.

Fixes: a1c82c5ebee ("drivers/generic/max98357a: Allow custom _HID from config")
Signed-off-by: Raul E Rangel 
Change-Id: I798ed08ef0a0575def12937a66a7ce99f743e60d
---
M src/drivers/generic/max98357a/max98357a.c
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/42014/1

diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c
index bd45296..575548b 100644
--- a/src/drivers/generic/max98357a/max98357a.c
+++ b/src/drivers/generic/max98357a/max98357a.c
@@ -26,15 +26,15 @@
    if (!scope || !name)
    	return;

-	/* Device */
-	acpigen_write_scope(scope);
-	acpigen_write_device(name);
-
    if (!config->hid) {
    	printk(BIOS_ERR, "%s: ERROR: _HID required\n", dev_path(dev));
    	return;
    }

+	/* Device */
+	acpigen_write_scope(scope);
+	acpigen_write_device(name);
+
    acpigen_write_name_string("_HID", config->hid);
    acpigen_write_name_integer("_UID", 0);
    acpigen_write_name_string("_DDN", dev->chip_ops->name);

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42014 )

Change subject: drivers/generic/max98357a: Don't write device if HID is missing
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42014 )

Change subject: drivers/generic/max98357a: Don't write device if HID is missing
......................................................................

drivers/generic/max98357a: Don't write device if HID is missing

If the device is missing the HID, the code would previously leave an
open scope and device on the stack.

BUG=b:154756391
TEST=Verify stack ACPI stack does not exceed limit on Trembyle.

Fixes: a1c82c5ebee ("drivers/generic/max98357a: Allow custom _HID from config")
Signed-off-by: Raul E Rangel 
Change-Id: I798ed08ef0a0575def12937a66a7ce99f743e60d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42014
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/drivers/generic/max98357a/max98357a.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c
index bd45296..575548b 100644
--- a/src/drivers/generic/max98357a/max98357a.c
+++ b/src/drivers/generic/max98357a/max98357a.c
@@ -26,15 +26,15 @@
    if (!scope || !name)
    	return;

-	/* Device */
-	acpigen_write_scope(scope);
-	acpigen_write_device(name);
-
    if (!config->hid) {
    	printk(BIOS_ERR, "%s: ERROR: _HID required\n", dev_path(dev));
    	return;
    }

+	/* Device */
+	acpigen_write_scope(scope);
+	acpigen_write_device(name);
+
    acpigen_write_name_string("_HID", config->hid);
    acpigen_write_name_integer("_UID", 0);
    acpigen_write_name_string("_DDN", dev->chip_ops->name);

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42014 )

Change subject: drivers/generic/max98357a: Don't write device if HID is missing
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4836
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4835
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4834
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4833

Please note: This test is under development and might not be accurate at all!