Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58924 )
Change subject: intel/strago: Fix some CHROMEOS guards ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/intel/strago/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58924/comment/3db61cc1_b011f0de PS2, Line 5: all-y += chromeos.c
Should continue to guard this file
Done
File src/mainboard/intel/strago/chromeos.c:
https://review.coreboot.org/c/coreboot/+/58924/comment/7d4c92c2_07058b3d PS5, Line 26: * This function might get queried early in romstage. The GPIOs have We have the same paragraph on some other boards. We'll fix these when we decide if any get_write_protect_state() implementation is worth maintaining.
-
Kyösti Mälkki (Code Review)