Change in coreboot[master]: mb/google/hatch/var/jinlon: Config WWAN_RESET

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: AMD...

Chen Wisley (Code Review)

19 Dec 2019 19 Dec '19

2:19 p.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37837 )

Change subject: mb/google/hatch/var/jinlon: Config WWAN_RESET ......................................................................

mb/google/hatch/var/jinlon: Config WWAN_RESET

jinlon support LTE, and remove NC configuration

BUG=none TEST=emerge-hatch coreboot

Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/jinlon/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/37837/1

diff --git a/src/mainboard/google/hatch/variants/jinlon/gpio.c b/src/mainboard/google/hatch/variants/jinlon/gpio.c index 7e475fa..4622a72 100644 --- a/src/mainboard/google/hatch/variants/jinlon/gpio.c +++ b/src/mainboard/google/hatch/variants/jinlon/gpio.c @@ -29,8 +29,6 @@ PAD_NC(GPP_A10, NONE), /* C12 : FPMCU_PCH_BOOT1 */ PAD_CFG_GPO(GPP_C12, 0, DEEP), - /* F1 : NC */ - PAD_NC(GPP_F1, NONE), /* F3 : MEM_STRAP_3 */ PAD_CFG_GPI(GPP_F3, NONE, PLTRST), /* F10 : MEM_STRAP_2 */

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Chen Wisley (Code Review)

19 Dec 19 Dec

2:36 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37837 )

Change subject: mb/google/hatch/var/jinlon: Config WWAN_RESET ......................................................................

Patch Set 2:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Gerrit-Change-Number: 37837 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 19 Dec 2019 14:36:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

3:54 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37837 )

Change subject: mb/google/hatch/var/jinlon: Config WWAN_RESET ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Gerrit-Change-Number: 37837 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 19 Dec 2019 15:54:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

4:06 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37837 )

Change subject: mb/google/hatch/var/jinlon: Config WWAN_RESET ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37837/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37837/2//COMMIT_MSG@9 PS2, Line 9: and remove … so remove

-- To view, visit https://review.coreboot.org/c/coreboot/+/37837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Gerrit-Change-Number: 37837 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 19 Dec 2019 16:06:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

20 Dec 20 Dec

1:04 a.m.

Hello Paul Fagerburg, Philip Chen, Tim Wawrzynczak, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37837

to look at the new patch set (#3).

Change subject: mb/google/hatch/var/jinlon: Config WWAN_RESET ......................................................................

mb/google/hatch/var/jinlon: Config WWAN_RESET

jinlon supports LTE, so remove WWAN_RESET NC configuration

BUG=none TEST=emerge-hatch coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/37837/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Gerrit-Change-Number: 37837 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

1:05 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37837 )

Change subject: mb/google/hatch/var/jinlon: Config WWAN_RESET ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37837/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/37837/2//COMMIT_MSG@9 PS2, Line 9: and remove

...

… so remove

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Gerrit-Change-Number: 37837 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Dec 2019 01:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:55 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37837 )

Change subject: mb/google/hatch/var/jinlon: Config WWAN_RESET ......................................................................

mb/google/hatch/var/jinlon: Config WWAN_RESET

jinlon supports LTE, so remove WWAN_RESET NC configuration

BUG=none TEST=emerge-hatch coreboot

Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37837 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/jinlon/gpio.c 1 file changed, 0 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Fagerburg: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/37837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5d21f0a33952f519265a5ce2df559a79346d9e Gerrit-Change-Number: 37837 Gerrit-PatchSet: 4 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1806

days inactive

1807

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Chen Wisley (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)