Change in coreboot[master]: mb/facebook/fbg1701: Remove ONBOARD_SAMSUNG_MEM

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59754 )

Change subject: mb/facebook/fbg1701: Remove ONBOARD_SAMSUNG_MEM
......................................................................

mb/facebook/fbg1701: Remove ONBOARD_SAMSUNG_MEM

CONFIG_ONBOARD_SAMSUMG_MEM was used to force Samsung memory.

CPLD returns different values for every board revision. Use this value
to determine the memory type.

BUG = N/A
TEST = Boot Facebook FBG1701 Rev 1.0 - 1.4

Change-Id: I21b5ddc430410a1e8b3e9012d0c07d278880ff47
Signed-off-by: Frans Hendriks 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59754
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Felix Held 
---
M src/mainboard/facebook/fbg1701/romstage.c
1 file changed, 17 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/mainboard/facebook/fbg1701/romstage.c b/src/mainboard/facebook/fbg1701/romstage.c
index fd005a6..7a31309 100644
--- a/src/mainboard/facebook/fbg1701/romstage.c
+++ b/src/mainboard/facebook/fbg1701/romstage.c
@@ -18,13 +18,24 @@
 void mainboard_memory_init_params(struct romstage_params *params,
    			  MEMORY_INIT_UPD *memory_params)
 {
-	u8 spd_index = 0;
+	u8 spd_index;

-	if (!CONFIG(ONBOARD_SAMSUNG_MEM)) {
-		if (cpld_read_pcb_version() <= 7)
-			spd_index = 1;
-		else
-			spd_index = 2;
+	switch (cpld_read_pcb_version()) {
+	case 0:	/* intentional fallthrough */
+	case 1:	/* intentional fallthrough */
+	case 2:	/* intentional fallthrough */
+	case 3:	/* intentional fallthrough */
+	case 4:	/* intentional fallthrough */
+	case 5:
+		spd_index = 0;
+		break;
+	case 6:	/* intentional fallthrough */
+	case 7:
+		spd_index = 1;
+		break;
+	default:
+		spd_index = 2;
+		break;
    }

memory_params->PcdMemoryTypeEnable = MEM_DDR3;