Attention is currently required from: Arthur Heymans, Marc Jones, Jonathan Zhang, Angel Pons, lichenchen.carl, Nill Ge.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64035 )
Change subject: arch/x86/smbios.c: Allow creating entries for empty DIMM slots
......................................................................
Patch Set 1:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/64035/comment/78c36aa5_5ad615c8
PS1, Line 281: *current
I just reused the signature of `create_smbios_type17_for_dimm()`. […]
Ack. I just noticed the whole file is full of such odd patterns.
https://review.coreboot.org/c/coreboot/+/64035/comment/b144c163_46969ae6
PS1, Line 291: t->form_factor = 0x2; /* Unknown */
It could be SO-DIMM in some cases.
Hmmm, if we expect that location info is filled for empty slots, should
we expect `form_factor` to be filled too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17ae83edf94483bd2eeef5524ff82721c196b8ba
Gerrit-Change-Number: 64035
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 04 May 2022 16:25:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment