Attention is currently required from: Chen-Tsung Hsieh, jitao shi, Shaoming Chen, Jitao Shi, Yu-Ping Wu.
Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 )
Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/62c79846_8146baa1
PS2, Line 207: 10
Ack
According to https://patchwork.kernel.org/project/linux-mediatek/patch/20210201033603.126...
delta = dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST ? 18 : 12;
If this is what we want, should we update coreboot as follow?
```
u32 delta = 12;
if (!(mode_flags & MIPI_DSI_MODE_EOT_PACKET))
delta += 2;
if (mode_flags & MIPI_DSI_MODE_VIDEO_BURST)
delta += 6;
```
(MIPI_DSI_MODE_EOT_PACKET is a disable bit in kernel, but an enable bit in coreboot.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c
Gerrit-Change-Number: 51432
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Attention: jitao shi
jitao.shi@mediatek.com
Gerrit-Attention: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 10:31:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@google.com
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@chromium.org
Comment-In-Reply-To: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-MessageType: comment