Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Paul Menzel.
Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57671 )
Change subject: driver/i2c/max98390: Add vmon_slot_no/imon_slot_no property
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/max98390/max98390.c:
https://review.coreboot.org/c/coreboot/+/57671/comment/a8b959ac_85189987
PS1, Line 82: if (!dp)
: dp = acpi_dp_new_table("_DSD");
:
: acpi_dp_add_integer(dp, "maxim,vmon-slot-no", config->vmon_slot_no);
: acpi_dp_add_integer(dp, "maxim,imon-slot-no", config->imon_slot_no);
from the driver: […]
We seems no need to have 'if (config->vmon_slot_no)', '(config->imon_slot_no)',
In case of the function needed, need to report vmon-slot-no, imon-slot-no.
in case of not using the function, it doesn't matter to have default reported.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57671
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb24d19c7cfea559bf6d53f401d66cadb8b3acc6
Gerrit-Change-Number: 57671
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 17 Sep 2021 10:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-MessageType: comment