HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42393 )
Change subject: src: Drop unused <cpu/x86/tsc.h> include ......................................................................
src: Drop unused <cpu/x86/tsc.h> include
Change-Id: Id090e232a96323adb8d9a24b81f7ae5669248f57 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/pc80/pc/spkmodem.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/braswell/acpi.c M src/soc/intel/broadwell/acpi.c M src/soc/intel/broadwell/refcode.c M src/soc/intel/skylake/acpi.c 6 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/42393/1
diff --git a/src/drivers/pc80/pc/spkmodem.c b/src/drivers/pc80/pc/spkmodem.c index 7b88c0a..ced544e 100644 --- a/src/drivers/pc80/pc/spkmodem.c +++ b/src/drivers/pc80/pc/spkmodem.c @@ -2,7 +2,6 @@
#include <arch/io.h> #include <console/spkmodem.h> -#include <cpu/x86/tsc.h>
#define SPEAKER_PIT_FREQUENCY 0x1234dd
diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c index d008dd8..43d0e90 100644 --- a/src/soc/intel/baytrail/acpi.c +++ b/src/soc/intel/baytrail/acpi.c @@ -9,7 +9,6 @@ #include <cpu/x86/smm.h> #include <types.h> #include <cpu/x86/msr.h> -#include <cpu/x86/tsc.h> #include <cpu/intel/turbo.h>
#include <soc/acpi.h> diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c index 0bac42c..03e7c05 100644 --- a/src/soc/intel/braswell/acpi.c +++ b/src/soc/intel/braswell/acpi.c @@ -9,7 +9,6 @@ #include <cpu/intel/turbo.h> #include <cpu/x86/msr.h> #include <cpu/x86/smm.h> -#include <cpu/x86/tsc.h> #include <device/pci.h> #include <ec/google/chromeec/ec.h> #include <drivers/intel/gma/opregion.h> diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c index fce2e45..bc99441 100644 --- a/src/soc/intel/broadwell/acpi.c +++ b/src/soc/intel/broadwell/acpi.c @@ -11,7 +11,6 @@ #include <string.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> -#include <cpu/x86/tsc.h> #include <cpu/intel/turbo.h> #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/gnvs.h> diff --git a/src/soc/intel/broadwell/refcode.c b/src/soc/intel/broadwell/refcode.c index 5e5bc49..882f888 100644 --- a/src/soc/intel/broadwell/refcode.c +++ b/src/soc/intel/broadwell/refcode.c @@ -5,7 +5,6 @@ #include <cbmem.h> #include <console/console.h> #include <console/streams.h> -#include <cpu/x86/tsc.h> #include <program_loading.h> #include <rmodule.h> #include <stage_cache.h> diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c index bdfacd3..71ecd0b 100644 --- a/src/soc/intel/skylake/acpi.c +++ b/src/soc/intel/skylake/acpi.c @@ -9,7 +9,6 @@ #include <console/console.h> #include <cpu/x86/smm.h> #include <cpu/x86/msr.h> -#include <cpu/x86/tsc.h> #include <cpu/intel/common/common.h> #include <cpu/intel/turbo.h> #include <ec/google/chromeec/ec.h>
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42393
to look at the new patch set (#2).
Change subject: src: Drop unused <cpu/x86/tsc.h> include ......................................................................
src: Drop unused <cpu/x86/tsc.h> include
Found using: diff <(git grep -l '#include <cpu/x86/tsc.h>' -- src/) <(git grep -l 'TSC_SYNC|tsc_struct|rdtsc|tsc_t|multiply_to_tsc|rdtscll|tsc_to_uint64|tsc_freq_mhz|tsc_constant_rate' -- src/)|grep '<'
Change-Id: Id090e232a96323adb8d9a24b81f7ae5669248f57 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/pc80/pc/spkmodem.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/braswell/acpi.c M src/soc/intel/broadwell/acpi.c M src/soc/intel/broadwell/refcode.c M src/soc/intel/skylake/acpi.c 6 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/42393/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42393 )
Change subject: src: Drop unused <cpu/x86/tsc.h> include ......................................................................
Abandoned
see 41969
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/42393 )
Change subject: src: Drop unused <cpu/x86/tsc.h> include ......................................................................
Restored
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42393 )
Change subject: src: Drop unused <cpu/x86/tsc.h> include ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42393 )
Change subject: src: Drop unused <cpu/x86/tsc.h> include ......................................................................
src: Drop unused <cpu/x86/tsc.h> include
Found using: diff <(git grep -l '#include <cpu/x86/tsc.h>' -- src/) <(git grep -l 'TSC_SYNC|tsc_struct|rdtsc|tsc_t|multiply_to_tsc|rdtscll|tsc_to_uint64|tsc_freq_mhz|tsc_constant_rate' -- src/)|grep '<'
Change-Id: Id090e232a96323adb8d9a24b81f7ae5669248f57 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42393 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/pc80/pc/spkmodem.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/braswell/acpi.c M src/soc/intel/broadwell/acpi.c M src/soc/intel/broadwell/refcode.c M src/soc/intel/skylake/acpi.c 6 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/drivers/pc80/pc/spkmodem.c b/src/drivers/pc80/pc/spkmodem.c index 7b88c0a..ced544e 100644 --- a/src/drivers/pc80/pc/spkmodem.c +++ b/src/drivers/pc80/pc/spkmodem.c @@ -2,7 +2,6 @@
#include <arch/io.h> #include <console/spkmodem.h> -#include <cpu/x86/tsc.h>
#define SPEAKER_PIT_FREQUENCY 0x1234dd
diff --git a/src/soc/intel/baytrail/acpi.c b/src/soc/intel/baytrail/acpi.c index 8267199..aa712eb 100644 --- a/src/soc/intel/baytrail/acpi.c +++ b/src/soc/intel/baytrail/acpi.c @@ -10,7 +10,6 @@ #include <cpu/x86/smm.h> #include <types.h> #include <cpu/x86/msr.h> -#include <cpu/x86/tsc.h> #include <cpu/intel/turbo.h>
#include <soc/acpi.h> diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c index 98d7980..557b449 100644 --- a/src/soc/intel/braswell/acpi.c +++ b/src/soc/intel/braswell/acpi.c @@ -10,7 +10,6 @@ #include <cpu/intel/turbo.h> #include <cpu/x86/msr.h> #include <cpu/x86/smm.h> -#include <cpu/x86/tsc.h> #include <device/pci.h> #include <ec/google/chromeec/ec.h> #include <drivers/intel/gma/opregion.h> diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c index 306d72f..2916831 100644 --- a/src/soc/intel/broadwell/acpi.c +++ b/src/soc/intel/broadwell/acpi.c @@ -12,7 +12,6 @@ #include <string.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> -#include <cpu/x86/tsc.h> #include <cpu/intel/turbo.h> #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/gnvs.h> diff --git a/src/soc/intel/broadwell/refcode.c b/src/soc/intel/broadwell/refcode.c index 5e5bc49..882f888 100644 --- a/src/soc/intel/broadwell/refcode.c +++ b/src/soc/intel/broadwell/refcode.c @@ -5,7 +5,6 @@ #include <cbmem.h> #include <console/console.h> #include <console/streams.h> -#include <cpu/x86/tsc.h> #include <program_loading.h> #include <rmodule.h> #include <stage_cache.h> diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c index 6da43e9..0ef8343 100644 --- a/src/soc/intel/skylake/acpi.c +++ b/src/soc/intel/skylake/acpi.c @@ -10,7 +10,6 @@ #include <console/console.h> #include <cpu/x86/smm.h> #include <cpu/x86/msr.h> -#include <cpu/x86/tsc.h> #include <cpu/intel/common/common.h> #include <cpu/intel/turbo.h> #include <ec/google/chromeec/ec.h>