HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42395 )
Change subject: cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include ......................................................................
cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include
Change-Id: Ib721e667144d6803261f3761a077570e0e27391d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_1067x/model_1067x_init.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42395/1
diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c index 7230213..cd774d3 100644 --- a/src/cpu/intel/model_1067x/model_1067x_init.c +++ b/src/cpu/intel/model_1067x/model_1067x_init.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <cpu/cpu.h> #include <cpu/x86/msr.h> -#include <cpu/x86/mp.h> #include <cpu/x86/lapic.h> #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h>
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42395
to look at the new patch set (#2).
Change subject: cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include ......................................................................
cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include
Found using: diff <(git grep -l 'include <cpu/x86/mp.h>' -- src) <(git rep -l 'CACHELINE_SIZE|cpu_info|mfence|mfence|mp_ops|mp_init_with_smm|MP_RUN_ON_ALL_CPUS|mp_run_on_aps|mp_run_on_all_cpus|mp_park_aps|smm_initiate_relocation_parallel|smm_initiate_relocation' -- src/) |grep '<'
Change-Id: Ib721e667144d6803261f3761a077570e0e27391d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_1067x/model_1067x_init.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42395/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42395 )
Change subject: cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include ......................................................................
Abandoned
see 41969
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/42395 )
Change subject: cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include ......................................................................
Restored
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42395
to look at the new patch set (#3).
Change subject: cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include ......................................................................
cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include
Found using: diff <(git grep -l 'include <cpu/x86/mp.h>' -- src) <(git grep -l 'CACHELINE_SIZE|cpu_info|mfence|mfence|mp_ops|mp_init_with_smm|MP_RUN_ON_ALL_CPUS|mp_run_on_aps|mp_run_on_all_cpus|mp_park_aps|smm_initiate_relocation_parallel|smm_initiate_relocation' -- src/) |grep '<'
Change-Id: Ib721e667144d6803261f3761a077570e0e27391d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/model_1067x/model_1067x_init.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/42395/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42395 )
Change subject: cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42395 )
Change subject: cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include ......................................................................
cpu/intel/model_1067x: Drop <cpu/x86/mp.h> include
Found using: diff <(git grep -l 'include <cpu/x86/mp.h>' -- src) <(git grep -l 'CACHELINE_SIZE|cpu_info|mfence|mfence|mp_ops|mp_init_with_smm|MP_RUN_ON_ALL_CPUS|mp_run_on_aps|mp_run_on_all_cpus|mp_park_aps|smm_initiate_relocation_parallel|smm_initiate_relocation' -- src/) |grep '<'
Change-Id: Ib721e667144d6803261f3761a077570e0e27391d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/42395 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/cpu/intel/model_1067x/model_1067x_init.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c index 6cb11fe..e040e0d 100644 --- a/src/cpu/intel/model_1067x/model_1067x_init.c +++ b/src/cpu/intel/model_1067x/model_1067x_init.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <cpu/cpu.h> #include <cpu/x86/msr.h> -#include <cpu/x86/mp.h> #include <cpu/x86/lapic.h> #include <cpu/intel/speedstep.h> #include <cpu/x86/cache.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)