HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41969 )
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
src: Remove unused 'include <cpu/x86/msr.h>'
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/drivers/intel/gma/intel_ddi.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/baytrail/include/soc/pattrs.h M src/soc/intel/braswell/include/soc/pattrs.h M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/denverton_ns/include/soc/pattrs.h M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 23 files changed, 0 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41969/1
diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c index 3955614..2beb890 100644 --- a/src/cpu/intel/speedstep/acpi.c +++ b/src/cpu/intel/speedstep/acpi.c @@ -5,7 +5,6 @@ #include <acpi/acpi.h> #include <acpi/acpigen.h> #include <arch/cpu.h> -#include <cpu/x86/msr.h> #include <cpu/intel/fsb.h> #include <cpu/intel/speedstep.h> #include <device/device.h> diff --git a/src/cpu/x86/lapic/apic_timer.c b/src/cpu/x86/lapic/apic_timer.c index 97c28bd..01a67fa 100644 --- a/src/cpu/x86/lapic/apic_timer.c +++ b/src/cpu/x86/lapic/apic_timer.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <delay.h> #include <thread.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic.h>
void init_timer(void) diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index a04789b..3893664 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -8,7 +8,6 @@ #include <device/pci.h> #include <ec/google/chromeec/ec.h> #include <cpu/x86/tsc.h> -#include <cpu/x86/msr.h> #include <edid.h> #include <drivers/intel/gma/i915.h>
diff --git a/src/mainboard/bap/ode_e21XX/mainboard.c b/src/mainboard/bap/ode_e21XX/mainboard.c index ce4a63c..b26722a 100644 --- a/src/mainboard/bap/ode_e21XX/mainboard.c +++ b/src/mainboard/bap/ode_e21XX/mainboard.c @@ -3,7 +3,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci_def.h> -#include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h>
/********************************************** diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index 3b4f14a..66fddd3 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -2,7 +2,6 @@
#include <acpi/acpi.h> #include <device/device.h> -#include <cpu/x86/msr.h>
#include <intelblocks/acpi.h> #include <soc/acpi.h> diff --git a/src/mainboard/kontron/ktqm77/early_init.c b/src/mainboard/kontron/ktqm77/early_init.c index b8f44b5..669577e 100644 --- a/src/mainboard/kontron/ktqm77/early_init.c +++ b/src/mainboard/kontron/ktqm77/early_init.c @@ -4,7 +4,6 @@ #include <stdint.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> -#include <cpu/x86/msr.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/lenovo/x220/early_init.c b/src/mainboard/lenovo/x220/early_init.c index 5f0ad45..e4c854c 100644 --- a/src/mainboard/lenovo/x220/early_init.c +++ b/src/mainboard/lenovo/x220/early_init.c @@ -7,7 +7,6 @@ #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> -#include <cpu/x86/msr.h>
void mainboard_fill_pei_data(struct pei_data *pei_data) { diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index 3b4f14a..66fddd3 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -2,7 +2,6 @@
#include <acpi/acpi.h> #include <device/device.h> -#include <cpu/x86/msr.h>
#include <intelblocks/acpi.h> #include <soc/acpi.h> diff --git a/src/northbridge/intel/e7505/raminit.c b/src/northbridge/intel/e7505/raminit.c index b87ba6e..63642d7 100644 --- a/src/northbridge/intel/e7505/raminit.c +++ b/src/northbridge/intel/e7505/raminit.c @@ -19,7 +19,6 @@ #include <lib.h> #include <commonlib/helpers.h> #include <console/console.h> -#include <cpu/x86/msr.h> #include <assert.h> #include <spd.h> #include <sdram_mode.h> diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c index d98af9e..7894dd3 100644 --- a/src/northbridge/intel/ironlake/northbridge.c +++ b/src/northbridge/intel/ironlake/northbridge.c @@ -6,7 +6,6 @@ #include <stdint.h> #include <delay.h> #include <cpu/intel/model_2065x/model_2065x.h> -#include <cpu/x86/msr.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/security/intel/stm/SmmStm.h b/src/security/intel/stm/SmmStm.h index c12b034..0447a9e 100644 --- a/src/security/intel/stm/SmmStm.h +++ b/src/security/intel/stm/SmmStm.h @@ -3,7 +3,6 @@ #ifndef _SMM_STM_H_ #define _SMM_STM_H_
-#include <cpu/x86/msr.h> #include "StmApi.h"
/* diff --git a/src/soc/amd/common/block/psp/psp.c b/src/soc/amd/common/block/psp/psp.c index 0e03174..2787b73 100644 --- a/src/soc/amd/common/block/psp/psp.c +++ b/src/soc/amd/common/block/psp/psp.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/mmio.h> -#include <cpu/x86/msr.h> #include <bootstate.h> #include <console/console.h> #include <amdblocks/psp.h> diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index 0bbceec..80bfa0a 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -3,7 +3,6 @@ #include <arch/cpu.h> #include <acpi/acpi.h> #include <cpu/x86/cache.h> -#include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <console/uart.h> #include <cbmem.h> diff --git a/src/soc/intel/apollolake/car.c b/src/soc/intel/apollolake/car.c index cbc43d5..fc6691b 100644 --- a/src/soc/intel/apollolake/car.c +++ b/src/soc/intel/apollolake/car.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <assert.h> -#include <cpu/x86/msr.h> #include <intelblocks/msr.h> #include <program_loading.h> #include <soc/cpu.h> diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index cc190ba..3558956 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -5,7 +5,6 @@ #include <cbmem.h> #include <console/console.h> #include <cpu/x86/mp.h> -#include <cpu/x86/msr.h> #include <device/mmio.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/baytrail/include/soc/pattrs.h b/src/soc/intel/baytrail/include/soc/pattrs.h index c1ca7f4..7c1be28 100644 --- a/src/soc/intel/baytrail/include/soc/pattrs.h +++ b/src/soc/intel/baytrail/include/soc/pattrs.h @@ -4,7 +4,6 @@ #define _PATTRS_H_
#include <stdint.h> -#include <cpu/x86/msr.h>
enum { IACORE_MIN, diff --git a/src/soc/intel/braswell/include/soc/pattrs.h b/src/soc/intel/braswell/include/soc/pattrs.h index 5cad6d0..89c6861 100644 --- a/src/soc/intel/braswell/include/soc/pattrs.h +++ b/src/soc/intel/braswell/include/soc/pattrs.h @@ -4,7 +4,6 @@ #define _SOC_PATTRS_H_
#include <stdint.h> -#include <cpu/x86/msr.h>
enum { IACORE_MIN, diff --git a/src/soc/intel/broadwell/cpu_info.c b/src/soc/intel/broadwell/cpu_info.c index 5542f17..506b1a7 100644 --- a/src/soc/intel/broadwell/cpu_info.c +++ b/src/soc/intel/broadwell/cpu_info.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <arch/cpu.h> -#include <cpu/x86/msr.h> #include <soc/cpu.h> #include <soc/msr.h> #include <soc/systemagent.h> diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index 70a9cac..6570c5c 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -8,7 +8,6 @@ #include <cf9_reset.h> #include <console/console.h> #include <cpu/intel/turbo.h> -#include <cpu/x86/msr.h> #include <cpu/x86/smm.h> #include <intelblocks/acpi.h> #include <intelblocks/msr.h> diff --git a/src/soc/intel/denverton_ns/include/soc/pattrs.h b/src/soc/intel/denverton_ns/include/soc/pattrs.h index 224c56d..47bb1e7 100644 --- a/src/soc/intel/denverton_ns/include/soc/pattrs.h +++ b/src/soc/intel/denverton_ns/include/soc/pattrs.h @@ -4,7 +4,6 @@ #define _DENVERTON_NS_PATTRS_H_
#include <stdint.h> -#include <cpu/x86/msr.h>
enum { IACORE_MIN, IACORE_LFM, IACORE_MAX, IACORE_TURBO, IACORE_END };
diff --git a/src/soc/intel/quark/include/soc/reg_access.h b/src/soc/intel/quark/include/soc/reg_access.h index 31df09d..1f186f7 100644 --- a/src/soc/intel/quark/include/soc/reg_access.h +++ b/src/soc/intel/quark/include/soc/reg_access.h @@ -4,7 +4,6 @@ #define _QUARK_REG_ACCESS_H_
#include <cpu/x86/cr.h> -#include <cpu/x86/msr.h> #include <fsp/util.h> #include <reg_script.h> #include <soc/IntelQNCConfig.h> diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c index dc97d5e..f69f0b9 100644 --- a/src/soc/intel/xeon_sp/skx/soc_util.c +++ b/src/soc/intel/xeon_sp/skx/soc_util.c @@ -3,7 +3,6 @@ #include <assert.h> #include <commonlib/sort.h> #include <console/console.h> -#include <cpu/x86/msr.h> #include <delay.h> #include <device/pci.h> #include <hob_iiouds.h> diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c index 8bca42b..14bb5e2 100644 --- a/src/southbridge/amd/pi/hudson/early_setup.c +++ b/src/southbridge/amd/pi/hudson/early_setup.c @@ -16,7 +16,6 @@
#if CONFIG(HUDSON_UART)
-#include <cpu/x86/msr.h> #include <delay.h>
void configure_hudson_uart(void)
Hello David Guckian, Vanessa Eusebio, Alexander Couzens, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41969
to look at the new patch set (#2).
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
src: Remove unused 'include <cpu/x86/msr.h>'
Found using: diff <(git grep -l '#include <cpu/x86/msr.h>' -- src/) <(git grep -l 'IA32_EFER|EFER_|TSC_MSR|IA32_|FEATURE_CONTROL_LOCK_BIT|FEATURE_ENABLE_VMX|SMRR_ENABLE|CPUID_|SGX_GLOBAL_ENABLE|PLATFORM_INFO_SET_TDP|SMBASE_RO_MSR|MCG_CTL_P|MCA_BANKS_MASK|FAST_STRINGS_ENABLE_BIT|SPEED_STEP_ENABLE_BIT|ENERGY_POLICY_|SMRR_PHYSMASK_|MCA_STATUS_|VMX_BASIC_HI_DUAL_MONITOR|MC0_ADDR|MC0_MISC|MC0_CTL_MASK|msr_struct|msrinit_struct|soc_msr_read|soc_msr_write|rdmsr|wrmsr|mca_valid|mca_over|mca_uc|mca_en|mca_miscv|mca_addrv|mca_pcc|mca_idv|mca_cecc|mca_uecc|mca_defd|mca_poison|mca_sublink|mca_err_code|mca_err_extcode|MCA_ERRCODE_|MCA_BANK_|MCA_ERRTYPE_|mca_err_type|msr_set_bit' -- src/) |grep '<'
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/drivers/intel/gma/intel_ddi.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/baytrail/include/soc/pattrs.h M src/soc/intel/braswell/include/soc/pattrs.h M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/denverton_ns/include/soc/pattrs.h M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 23 files changed, 0 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41969/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41969 )
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41969/2/src/soc/intel/apollolake/ch... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/41969/2/src/soc/intel/apollolake/ch... PS2, Line 3: #include <acpi/acpi.h> : #include <bootstate.h> : #include <cbmem.h> : #include <console/console.h> : #include <cpu/x86/mp.h> : #include <cpu/x86/msr.h> : #include <device/mmio.h> : #include <device/device.h> : #include <device/pci.h> : #include <device/pci_ops.h> : #include <intelblocks/acpi.h> : #include <intelblocks/cfg.h> : #include <intelblocks/fast_spi.h> : #include <intelblocks/msr.h> : #include <intelblocks/p2sb.h> : #include <intelblocks/power_limit.h> : #include <intelblocks/xdci.h> : #include <fsp/api.h> : #include <fsp/util.h> : #include <intelblocks/cpulib.h> : #include <intelblocks/itss.h> : #include <intelblocks/pmclib.h> : #include <romstage_handoff.h> : #include <soc/cpu.h> : #include <soc/heci.h> : #include <soc/intel/common/vbt.h> : #include <soc/iomap.h> : #include <soc/itss.h> : #include <soc/nvs.h> : #include <soc/pci_devs.h> : #include <soc/pm.h> : #include <soc/systemagent.h> : #include <spi-generic.h> : #include <timer.h> : #include <soc/ramstage.h> : #include <soc/soc_chip.h> include <TheUniverse.h> :)
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Angel Pons, Alexander Couzens, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41969
to look at the new patch set (#3).
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
src: Remove unused 'include <cpu/x86/msr.h>'
Found using: diff <(git grep -l '#include <cpu/x86/msr.h>' -- src/) <(git grep -l 'IA32_EFER|EFER_|TSC_MSR|IA32_|FEATURE_CONTROL_LOCK_BIT|FEATURE_ENABLE_VMX|SMRR_ENABLE|CPUID_|SGX_GLOBAL_ENABLE|PLATFORM_INFO_SET_TDP|SMBASE_RO_MSR|MCG_CTL_P|MCA_BANKS_MASK|FAST_STRINGS_ENABLE_BIT|SPEED_STEP_ENABLE_BIT|ENERGY_POLICY_|SMRR_PHYSMASK_|MCA_STATUS_|VMX_BASIC_HI_DUAL_MONITOR|MC0_ADDR|MC0_MISC|MC0_CTL_MASK|msr_struct|msrinit_struct|soc_msr_read|soc_msr_write|rdmsr|wrmsr|mca_valid|mca_over|mca_uc|mca_en|mca_miscv|mca_addrv|mca_pcc|mca_idv|mca_cecc|mca_uecc|mca_defd|mca_poison|mca_sublink|mca_err_code|mca_err_extcode|MCA_ERRCODE_|MCA_BANK_|MCA_ERRTYPE_|mca_err_type|msr_set_bit|msr_t|msrinit_t' -- src/) |grep '<
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/drivers/intel/gma/intel_ddi.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 20 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41969/3
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Angel Pons, Alexander Couzens, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41969
to look at the new patch set (#4).
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
src: Remove unused 'include <cpu/x86/msr.h>'
Found using: diff <(git grep -l '#include <cpu/x86/msr.h>' -- src/) <(git grep -l 'IA32_EFER|EFER_|TSC_MSR|IA32_|FEATURE_CONTROL_LOCK_BIT|FEATURE_ENABLE_VMX|SMRR_ENABLE|CPUID_|SGX_GLOBAL_ENABLE|PLATFORM_INFO_SET_TDP|SMBASE_RO_MSR|MCG_CTL_P|MCA_BANKS_MASK|FAST_STRINGS_ENABLE_BIT|SPEED_STEP_ENABLE_BIT|ENERGY_POLICY_|SMRR_PHYSMASK_|MCA_STATUS_|VMX_BASIC_HI_DUAL_MONITOR|MC0_ADDR|MC0_MISC|MC0_CTL_MASK|msr_struct|msrinit_struct|soc_msr_read|soc_msr_write|rdmsr|wrmsr|mca_valid|mca_over|mca_uc|mca_en|mca_miscv|mca_addrv|mca_pcc|mca_idv|mca_cecc|mca_uecc|mca_defd|mca_poison|mca_sublink|mca_err_code|mca_err_extcode|MCA_ERRCODE_|MCA_BANK_|MCA_ERRTYPE_|mca_err_type|msr_set_bit|msr_t|msrinit_t' -- src/) |grep '<'
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/drivers/intel/gma/intel_ddi.c M src/mainboard/bap/ode_e21XX/mainboard.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 20 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41969/4
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Angel Pons, Alexander Couzens, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41969
to look at the new patch set (#11).
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
src: Remove unused 'include <cpu/x86/msr.h>'
Found using: diff <(git grep -l '#include <cpu/x86/msr.h>' -- src/) <(git grep -l 'IA32_EFER|EFER_|TSC_MSR|IA32_|FEATURE_CONTROL_LOCK_BIT|FEATURE_ENABLE_VMX|SMRR_ENABLE|CPUID_|SGX_GLOBAL_ENABLE|PLATFORM_INFO_SET_TDP|SMBASE_RO_MSR|MCG_CTL_P|MCA_BANKS_MASK|FAST_STRINGS_ENABLE_BIT|SPEED_STEP_ENABLE_BIT|ENERGY_POLICY_|SMRR_PHYSMASK_|MCA_STATUS_|VMX_BASIC_HI_DUAL_MONITOR|MC0_ADDR|MC0_MISC|MC0_CTL_MASK|msr_struct|msrinit_struct|soc_msr_read|soc_msr_write|rdmsr|wrmsr|mca_valid|mca_over|mca_uc|mca_en|mca_miscv|mca_addrv|mca_pcc|mca_idv|mca_cecc|mca_uecc|mca_defd|mca_poison|mca_sublink|mca_err_code|mca_err_extcode|MCA_ERRCODE_|MCA_BANK_|MCA_ERRTYPE_|mca_err_type|msr_set_bit|msr_t|msrinit_t' -- src/) |grep '<'
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/drivers/intel/gma/intel_ddi.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 19 files changed, 0 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41969/11
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Angel Pons, Alexander Couzens, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41969
to look at the new patch set (#12).
Change subject: src: Remove unused 'include <cpu/x/x.h>' ......................................................................
src: Remove unused 'include <cpu/x/x.h>'
Remove unused include <cpu/x86/smm.h>: Found using: diff <(git grep -l '#include <cpu/x86/smm.h>' -- src/) <(git grep -l 'SMM_DEFAULT_BASE|SMM_DEFAULT_SIZE|SMM_BASE|SMM_ENTRY_OFFSET|SMM_SAVE_STATE_BEGIN|APM_CNT|APM_STS|apm_control|set_smm_gnvs_ptr|set_acpi_mode_on_exit|io_trap_handler|southbridge_io_trap_handler|mainboard_io_trap_handler|southbridge_smi_set_eos|smm_southbridge_clear_state|global_smi_enable|global_smi_enable_no_pwrbtn|cpu_smi_handler|northbridge_smi_handler|southbridge_smi_handler|mainboard_smi_gpi|mainboard_smi_apmc|mainboard_smi_sleep|smramc_dev|smramc_reg|run_smm_relocate|smm_is_really_enabled|is_smm_enabled|smram_open|smram_close|smram_lock|smm_open|smm_close|smm_lock|_binary_smm_start|_binary_smm_end|smm_runtime|smm_module_params|smm_handler_start|smm_get_save_state|smm_handler_t|smm_loader_params|smm_setup_relocation_handler|smm_load_module|backup_default_smm_area|restore_default_smm_area|smm_region|SMM_SUBREGION_HANDLER|SMM_SUBREGION_CACHE|SMM_SUBREGION_CHIPSET|SMM_SUBREGION_NUM|smm_subregion|smm_list_regions' -- src/)|grep '>'
Drop <cpu/x86/mp.h> include: Found using: diff <(git grep -l 'include <cpu/x86/mp.h>' -- src) <(git rep -l 'CACHELINE_SIZE|cpu_info|mfence|mfence|mp_ops|mp_init_with_smm|MP_RUN_ON_ALL_CPUS|mp_run_on_aps|mp_run_on_all_cpus|mp_park_aps|smm_initiate_relocation_parallel|smm_initiate_relocation' -- src/) |grep '<'
Remove unused 'include <cpu/intel/common/common.h>: Found using: diff <(git grep -l '#include <cpu/intel/common/common.h>' -- src/) <(git grep -l 'set_vmx_and_lock|set_feature_ctrl_vmx|set_feature_ctrl_lock|cppc_config|cpu_init_cppc_config|intel_ht_sibling' -- src/) |grep '<'
Drop unused <cpu/x86/tsc.h> include: Found using: diff <(git grep -l '#include <cpu/x86/tsc.h>' -- src/) <(git grep -l 'TSC_SYNC|tsc_struct|rdtsc|tsc_t|multiply_to_tsc|rdtscll|tsc_to_uint64|tsc_freq_mhz|tsc_constant_rate' -- src/)|grep '<'
Remove unused 'include <cpu/cpu.h>'. Remove unused 'include <cpu/x86/msr.h>': Found using: diff <(git grep -l '#include <cpu/x86/msr.h>' -- src/) <(git grep -l 'IA32_EFER|EFER_|TSC_MSR|IA32_|FEATURE_CONTROL_LOCK_BIT|FEATURE_ENABLE_VMX|SMRR_ENABLE|CPUID_|SGX_GLOBAL_ENABLE|PLATFORM_INFO_SET_TDP|SMBASE_RO_MSR|MCG_CTL_P|MCA_BANKS_MASK|FAST_STRINGS_ENABLE_BIT|SPEED_STEP_ENABLE_BIT|ENERGY_POLICY_|SMRR_PHYSMASK_|MCA_STATUS_|VMX_BASIC_HI_DUAL_MONITOR|MC0_ADDR|MC0_MISC|MC0_CTL_MASK|msr_struct|msrinit_struct|soc_msr_read|soc_msr_write|rdmsr|wrmsr|mca_valid|mca_over|mca_uc|mca_en|mca_miscv|mca_addrv|mca_pcc|mca_idv|mca_cecc|mca_uecc|mca_defd|mca_poison|mca_sublink|mca_err_code|mca_err_extcode|MCA_ERRCODE_|MCA_BANK_|MCA_ERRTYPE_|mca_err_type|msr_set_bit|msr_t|msrinit_t' -- src/) |grep '<'
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/postcar_loader.c M src/cpu/intel/model_1067x/model_1067x_init.c M src/cpu/intel/model_106cx/model_106cx_init.c M src/cpu/intel/model_6ex/model_6ex_init.c M src/cpu/intel/model_6fx/model_6fx_init.c M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/drivers/intel/gma/intel_ddi.c M src/drivers/pc80/pc/spkmodem.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/baytrail/acpi.c M src/soc/intel/braswell/acpi.c M src/soc/intel/broadwell/acpi.c M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/broadwell/refcode.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/skylake/acpi.c M src/soc/intel/skylake/romstage/romstage.c M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 31 files changed, 1 insertion(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41969/12
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41969 )
Change subject: src: Remove unused 'include <cpu/x/x.h>' ......................................................................
Patch Set 12:
Please remove x86-smi-mp topic where you applied it.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41969 )
Change subject: src: Remove unused 'include <cpu/x/x.h>' ......................................................................
Abandoned
Merge conflicts
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/41969 )
Change subject: src: Remove unused 'include <cpu/x/x.h>' ......................................................................
Restored
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio, Angel Pons, Alexander Couzens, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41969
to look at the new patch set (#13).
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
src: Remove unused 'include <cpu/x86/msr.h>'
Found using: diff <(git grep -l '#include <cpu/x86/msr.h>' -- src/) <(git grep -l 'IA32_EFER|EFER_|TSC_MSR|IA32_|FEATURE_CONTROL_LOCK_BIT|FEATURE_ENABLE_VMX|SMRR_ENABLE|CPUID_|SGX_GLOBAL_ENABLE|PLATFORM_INFO_SET_TDP|SMBASE_RO_MSR|MCG_CTL_P|MCA_BANKS_MASK|FAST_STRINGS_ENABLE_BIT|SPEED_STEP_ENABLE_BIT|ENERGY_POLICY_|SMRR_PHYSMASK_|MCA_STATUS_|VMX_BASIC_HI_DUAL_MONITOR|MC0_ADDR|MC0_MISC|MC0_CTL_MASK|msr_struct|msrinit_struct|soc_msr_read|soc_msr_write|rdmsr|wrmsr|mca_valid|mca_over|mca_uc|mca_en|mca_miscv|mca_addrv|mca_pcc|mca_idv|mca_cecc|mca_uecc|mca_defd|mca_poison|mca_sublink|mca_err_code|mca_err_extcode|MCA_ERRCODE_|MCA_BANK_|MCA_ERRTYPE_|mca_err_type|msr_set_bit|msr_t|msrinit_t' -- src/) |grep '<'
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 18 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/41969/13
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41969 )
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
Patch Set 15: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41969 )
Change subject: src: Remove unused 'include <cpu/x86/msr.h>' ......................................................................
src: Remove unused 'include <cpu/x86/msr.h>'
Found using: diff <(git grep -l '#include <cpu/x86/msr.h>' -- src/) <(git grep -l 'IA32_EFER|EFER_|TSC_MSR|IA32_|FEATURE_CONTROL_LOCK_BIT|FEATURE_ENABLE_VMX|SMRR_ENABLE|CPUID_|SGX_GLOBAL_ENABLE|PLATFORM_INFO_SET_TDP|SMBASE_RO_MSR|MCG_CTL_P|MCA_BANKS_MASK|FAST_STRINGS_ENABLE_BIT|SPEED_STEP_ENABLE_BIT|ENERGY_POLICY_|SMRR_PHYSMASK_|MCA_STATUS_|VMX_BASIC_HI_DUAL_MONITOR|MC0_ADDR|MC0_MISC|MC0_CTL_MASK|msr_struct|msrinit_struct|soc_msr_read|soc_msr_write|rdmsr|wrmsr|mca_valid|mca_over|mca_uc|mca_en|mca_miscv|mca_addrv|mca_pcc|mca_idv|mca_cecc|mca_uecc|mca_defd|mca_poison|mca_sublink|mca_err_code|mca_err_extcode|MCA_ERRCODE_|MCA_BANK_|MCA_ERRTYPE_|mca_err_type|msr_set_bit|msr_t|msrinit_t' -- src/) |grep '<'
Change-Id: I45a41e77e5269969280e9f95cfc0effe7f117a40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41969 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/cpu/intel/speedstep/acpi.c M src/cpu/x86/lapic/apic_timer.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/early_init.c M src/mainboard/scaleway/tagada/acpi_tables.c M src/northbridge/intel/e7505/raminit.c M src/northbridge/intel/ironlake/northbridge.c M src/security/intel/stm/SmmStm.h M src/soc/amd/common/block/psp/psp.c M src/soc/amd/picasso/romstage.c M src/soc/intel/apollolake/car.c M src/soc/intel/apollolake/chip.c M src/soc/intel/broadwell/cpu_info.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/quark/include/soc/reg_access.h M src/soc/intel/xeon_sp/skx/soc_util.c M src/southbridge/amd/pi/hudson/early_setup.c 18 files changed, 0 insertions(+), 18 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c index 3955614..2beb890 100644 --- a/src/cpu/intel/speedstep/acpi.c +++ b/src/cpu/intel/speedstep/acpi.c @@ -5,7 +5,6 @@ #include <acpi/acpi.h> #include <acpi/acpigen.h> #include <arch/cpu.h> -#include <cpu/x86/msr.h> #include <cpu/intel/fsb.h> #include <cpu/intel/speedstep.h> #include <device/device.h> diff --git a/src/cpu/x86/lapic/apic_timer.c b/src/cpu/x86/lapic/apic_timer.c index 97c28bd..01a67fa 100644 --- a/src/cpu/x86/lapic/apic_timer.c +++ b/src/cpu/x86/lapic/apic_timer.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <delay.h> #include <thread.h> -#include <cpu/x86/msr.h> #include <cpu/x86/lapic.h>
void init_timer(void) diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index e91b3b0..c51bd69 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -3,7 +3,6 @@ #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> #include <device/device.h> -#include <cpu/x86/msr.h>
#include <intelblocks/acpi.h> #include <soc/acpi.h> diff --git a/src/mainboard/kontron/ktqm77/early_init.c b/src/mainboard/kontron/ktqm77/early_init.c index b8f44b5..669577e 100644 --- a/src/mainboard/kontron/ktqm77/early_init.c +++ b/src/mainboard/kontron/ktqm77/early_init.c @@ -4,7 +4,6 @@ #include <stdint.h> #include <device/pnp_ops.h> #include <device/pci_ops.h> -#include <cpu/x86/msr.h> #include <device/pci_def.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <northbridge/intel/sandybridge/raminit.h> diff --git a/src/mainboard/lenovo/x220/early_init.c b/src/mainboard/lenovo/x220/early_init.c index 5f0ad45..e4c854c 100644 --- a/src/mainboard/lenovo/x220/early_init.c +++ b/src/mainboard/lenovo/x220/early_init.c @@ -7,7 +7,6 @@ #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> -#include <cpu/x86/msr.h>
void mainboard_fill_pei_data(struct pei_data *pei_data) { diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index e91b3b0..c51bd69 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -3,7 +3,6 @@ #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> #include <device/device.h> -#include <cpu/x86/msr.h>
#include <intelblocks/acpi.h> #include <soc/acpi.h> diff --git a/src/northbridge/intel/e7505/raminit.c b/src/northbridge/intel/e7505/raminit.c index 404ab2f..a528083 100644 --- a/src/northbridge/intel/e7505/raminit.c +++ b/src/northbridge/intel/e7505/raminit.c @@ -20,7 +20,6 @@ #include <lib.h> #include <commonlib/helpers.h> #include <console/console.h> -#include <cpu/x86/msr.h> #include <assert.h> #include <spd.h> #include <sdram_mode.h> diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c index 81bb0e7..c1a2840 100644 --- a/src/northbridge/intel/ironlake/northbridge.c +++ b/src/northbridge/intel/ironlake/northbridge.c @@ -6,7 +6,6 @@ #include <stdint.h> #include <delay.h> #include <cpu/intel/model_2065x/model_2065x.h> -#include <cpu/x86/msr.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/security/intel/stm/SmmStm.h b/src/security/intel/stm/SmmStm.h index c12b034..0447a9e 100644 --- a/src/security/intel/stm/SmmStm.h +++ b/src/security/intel/stm/SmmStm.h @@ -3,7 +3,6 @@ #ifndef _SMM_STM_H_ #define _SMM_STM_H_
-#include <cpu/x86/msr.h> #include "StmApi.h"
/* diff --git a/src/soc/amd/common/block/psp/psp.c b/src/soc/amd/common/block/psp/psp.c index 0e03174..2787b73 100644 --- a/src/soc/amd/common/block/psp/psp.c +++ b/src/soc/amd/common/block/psp/psp.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/mmio.h> -#include <cpu/x86/msr.h> #include <bootstate.h> #include <console/console.h> #include <amdblocks/psp.h> diff --git a/src/soc/amd/picasso/romstage.c b/src/soc/amd/picasso/romstage.c index 7d086fe..6855bf6 100644 --- a/src/soc/amd/picasso/romstage.c +++ b/src/soc/amd/picasso/romstage.c @@ -3,7 +3,6 @@ #include <arch/cpu.h> #include <acpi/acpi.h> #include <cpu/x86/cache.h> -#include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <console/uart.h> #include <cbmem.h> diff --git a/src/soc/intel/apollolake/car.c b/src/soc/intel/apollolake/car.c index cbc43d5..fc6691b 100644 --- a/src/soc/intel/apollolake/car.c +++ b/src/soc/intel/apollolake/car.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <assert.h> -#include <cpu/x86/msr.h> #include <intelblocks/msr.h> #include <program_loading.h> #include <soc/cpu.h> diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c index dd7dd1a..92edbad 100644 --- a/src/soc/intel/apollolake/chip.c +++ b/src/soc/intel/apollolake/chip.c @@ -5,7 +5,6 @@ #include <cbmem.h> #include <console/console.h> #include <cpu/x86/mp.h> -#include <cpu/x86/msr.h> #include <device/mmio.h> #include <device/device.h> #include <device/pci.h> diff --git a/src/soc/intel/broadwell/cpu_info.c b/src/soc/intel/broadwell/cpu_info.c index 5542f17..506b1a7 100644 --- a/src/soc/intel/broadwell/cpu_info.c +++ b/src/soc/intel/broadwell/cpu_info.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <arch/cpu.h> -#include <cpu/x86/msr.h> #include <soc/cpu.h> #include <soc/msr.h> #include <soc/systemagent.h> diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index 5e4c6e8..05d14ec 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -9,7 +9,6 @@ #include <acpi/acpi_gnvs.h> #include <console/console.h> #include <cpu/intel/turbo.h> -#include <cpu/x86/msr.h> #include <cpu/x86/smm.h> #include <intelblocks/acpi.h> #include <intelblocks/msr.h> diff --git a/src/soc/intel/quark/include/soc/reg_access.h b/src/soc/intel/quark/include/soc/reg_access.h index 31df09d..1f186f7 100644 --- a/src/soc/intel/quark/include/soc/reg_access.h +++ b/src/soc/intel/quark/include/soc/reg_access.h @@ -4,7 +4,6 @@ #define _QUARK_REG_ACCESS_H_
#include <cpu/x86/cr.h> -#include <cpu/x86/msr.h> #include <fsp/util.h> #include <reg_script.h> #include <soc/IntelQNCConfig.h> diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c index dc97d5e..f69f0b9 100644 --- a/src/soc/intel/xeon_sp/skx/soc_util.c +++ b/src/soc/intel/xeon_sp/skx/soc_util.c @@ -3,7 +3,6 @@ #include <assert.h> #include <commonlib/sort.h> #include <console/console.h> -#include <cpu/x86/msr.h> #include <delay.h> #include <device/pci.h> #include <hob_iiouds.h> diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c index 8bca42b..14bb5e2 100644 --- a/src/southbridge/amd/pi/hudson/early_setup.c +++ b/src/southbridge/amd/pi/hudson/early_setup.c @@ -16,7 +16,6 @@
#if CONFIG(HUDSON_UART)
-#include <cpu/x86/msr.h> #include <delay.h>
void configure_hudson_uart(void)
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)