Attention is currently required from: Kyösti Mälkki. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55199 )
Change subject: [RFC,WIP] cpu/x86/lapic: Drop xapic_write_atomic() ......................................................................
Patch Set 12: Code-Review+2
(2 comments)
Patchset:
PS12:
Very nice! […]
ah nvm I was not reading this correctly, I misread. It still seems fine to me, but it would be nice to have someone more knowledgable take a look.
PS12: further discussion has convinced me this is fine. I think this text in the commit message could be useful, modified to suit: "Remove code which was only needed for B and C2 stepping of P54C"
* See if we have a good local APIC by checking for buggy Pentia, * i.e. all B steppings and the C2 stepping of P54C when using their * integrated APIC (see 11AP erratum in "Pentium Processor * Specification Update").
-
ron minnich (Code Review)