Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32929
Change subject: soc/amd/common: Clean up prototypes for AcpiMmio ......................................................................
soc/amd/common: Clean up prototypes for AcpiMmio
Reorder the biosram prototypes to match the rest of the file. Remove prototypes for asf 32-bit functions that have not been implemented.
Change-Id: Ic2663158d8a71952c26eb37f34342a6ea5e58a42 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/32929/1
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index e1cf7cb..34e9ce9 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -44,9 +44,9 @@ void pm2_write16(uint8_t reg, uint16_t value); void pm2_write32(uint8_t reg, uint32_t value); uint8_t biosram_read8(uint8_t offset); -void biosram_write8(uint8_t offset, uint8_t value); uint16_t biosram_read16(uint8_t offset); uint32_t biosram_read32(uint8_t offset); +void biosram_write8(uint8_t offset, uint8_t value); void biosram_write16(uint8_t offset, uint16_t value); void biosram_write32(uint8_t offset, uint32_t value); uint8_t acpi_read8(uint8_t reg); @@ -57,10 +57,8 @@ void acpi_write32(uint8_t reg, uint32_t value); uint8_t asf_read8(uint8_t reg); uint16_t asf_read16(uint8_t reg); -uint32_t asf_read32(uint8_t reg); void asf_write8(uint8_t reg, uint8_t value); void asf_write16(uint8_t reg, uint16_t value); -void asf_write32(uint8_t reg, uint32_t value); uint8_t smbus_read8(uint8_t reg); uint16_t smbus_read16(uint8_t reg); void smbus_write8(uint8_t reg, uint8_t value);
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32929 )
Change subject: soc/amd/common: Clean up prototypes for AcpiMmio ......................................................................
Patch Set 1: Code-Review+2
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32929 )
Change subject: soc/amd/common: Clean up prototypes for AcpiMmio ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32929 )
Change subject: soc/amd/common: Clean up prototypes for AcpiMmio ......................................................................
soc/amd/common: Clean up prototypes for AcpiMmio
Reorder the biosram prototypes to match the rest of the file. Remove prototypes for asf 32-bit functions that have not been implemented.
Change-Id: Ic2663158d8a71952c26eb37f34342a6ea5e58a42 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32929 Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/include/amdblocks/acpimmio.h 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Richard Spiegel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h index e1cf7cb..34e9ce9 100644 --- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h +++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h @@ -44,9 +44,9 @@ void pm2_write16(uint8_t reg, uint16_t value); void pm2_write32(uint8_t reg, uint32_t value); uint8_t biosram_read8(uint8_t offset); -void biosram_write8(uint8_t offset, uint8_t value); uint16_t biosram_read16(uint8_t offset); uint32_t biosram_read32(uint8_t offset); +void biosram_write8(uint8_t offset, uint8_t value); void biosram_write16(uint8_t offset, uint16_t value); void biosram_write32(uint8_t offset, uint32_t value); uint8_t acpi_read8(uint8_t reg); @@ -57,10 +57,8 @@ void acpi_write32(uint8_t reg, uint32_t value); uint8_t asf_read8(uint8_t reg); uint16_t asf_read16(uint8_t reg); -uint32_t asf_read32(uint8_t reg); void asf_write8(uint8_t reg, uint8_t value); void asf_write16(uint8_t reg, uint16_t value); -void asf_write32(uint8_t reg, uint32_t value); uint8_t smbus_read8(uint8_t reg); uint16_t smbus_read16(uint8_t reg); void smbus_write8(uint8_t reg, uint8_t value);
-
Furquan Shaikh (Code Review) -
Marshall Dawson (Code Review)
-
Martin Roth (Code Review)
-
Richard Spiegel (Code Review)