HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36508 )
Change subject: mb/google/kukui: Unselect FATAL_ASSERT ......................................................................
mb/google/kukui: Unselect FATAL_ASSERT
FATAL_ASSERT is used for debugging purpos. Don't select it by default.
Change-Id: If4d521827f3d50fb662b89b24d00fb0517e7af2d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/kukui/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/36508/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 542ee10..e6d604e 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -32,7 +32,6 @@ select CHROMEOS_USE_EC_WATCHDOG_FLAG if CHROMEOS select COMMON_CBFS_SPI_WRAPPER select SPI_FLASH - select FATAL_ASSERTS select SPI_FLASH_INCLUDE_ALL_DRIVERS select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36508 )
Change subject: mb/google/kukui: Unselect FATAL_ASSERT ......................................................................
Patch Set 1:
Yeah, I don't know why this is here... for Chrome OS boards, this is manually selected by the Chrome OS build system for debug builds, it shouldn't be forced on. Hung-Te?
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36508 )
Change subject: mb/google/kukui: Unselect FATAL_ASSERT ......................................................................
Patch Set 1: Code-Review+2
LGTM
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36508 )
Change subject: mb/google/kukui: Unselect FATAL_ASSERT ......................................................................
mb/google/kukui: Unselect FATAL_ASSERT
FATAL_ASSERT is used for debugging purpos. Don't select it by default.
Change-Id: If4d521827f3d50fb662b89b24d00fb0517e7af2d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36508 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/mainboard/google/kukui/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 542ee10..e6d604e 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -32,7 +32,6 @@ select CHROMEOS_USE_EC_WATCHDOG_FLAG if CHROMEOS select COMMON_CBFS_SPI_WRAPPER select SPI_FLASH - select FATAL_ASSERTS select SPI_FLASH_INCLUDE_ALL_DRIVERS select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID
-
HAOUAS Elyes (Code Review) -
Hung-Te Lin (Code Review)
-
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)