coreboot@s.paape.io has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40755 )
Change subject: fix: gemini lake device id is LPC ......................................................................
fix: gemini lake device id is LPC
Change-Id: If6a22a28f2a4ca1f984b669b00bc0c07f5588328 --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/pcr.c 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/40755/1
diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c index 471485c..e11d848 100644 --- a/util/inteltool/gpio.c +++ b/util/inteltool/gpio.c @@ -1035,7 +1035,7 @@ case PCI_DEVICE_ID_INTEL_QM170: case PCI_DEVICE_ID_INTEL_HM170: case PCI_DEVICE_ID_INTEL_CM236: - case PCI_DEVICE_ID_INTEL_GLK: + case PCI_DEVICE_ID_INTEL_GLK_LPC: case PCI_DEVICE_ID_INTEL_APL_LPC: case PCI_DEVICE_ID_INTEL_DNV_LPC: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_PRE: diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index a4bfdcb..475f701 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -316,7 +316,7 @@ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C224, "C224"}, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C226, "C226"}, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H81, "H81"}, - { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_GLK, "Gemini Lake" }, + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_GLK_LPC, "Gemini Lake" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_APL_LPC, "Apollo Lake" }, { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_LPC, "Denverton" }, /* Intel GPUs */ diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index 9f5d8aa..9eff45d 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -267,7 +267,7 @@ #define PCI_DEVICE_ID_INTEL_BAYTRAIL_GFX 0x0f31 #define CPUID_BAYTRAIL 0x30670
-#define PCI_DEVICE_ID_INTEL_GLK 0x31e8 +#define PCI_DEVICE_ID_INTEL_GLK_LPC 0x31e8 #define PCI_DEVICE_ID_INTEL_APL_LPC 0x5ae8 #define PCI_DEVICE_ID_INTEL_DNV_LPC 0x19dc
diff --git a/util/inteltool/pcr.c b/util/inteltool/pcr.c index 963a8b4..4733458 100644 --- a/util/inteltool/pcr.c +++ b/util/inteltool/pcr.c @@ -120,7 +120,7 @@ p2sb = pci_get_dev(sb->access, 0, 0, 0x1f, 1); break; case PCI_DEVICE_ID_INTEL_APL_LPC: - case PCI_DEVICE_ID_INTEL_GLK: + case PCI_DEVICE_ID_INTEL_GLK_LPC: p2sb = pci_get_dev(sb->access, 0, 0, 0x0d, 0); break; case PCI_DEVICE_ID_INTEL_H310:
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40755 )
Change subject: fix: gemini lake device id is LPC ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40755/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40755/1//COMMIT_MSG@7 PS1, Line 7: fix: gemini lake device id is LPC Do you mean:
inteltool: Fix macro name for Gemini Lake LPC device id
https://review.coreboot.org/c/coreboot/+/40755/1//COMMIT_MSG@9 PS1, Line 9: Change-Id: If6a22a28f2a4ca1f984b669b00bc0c07f5588328 Your Signed-off-by line is missing.
Hello build bot (Jenkins), Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40755
to look at the new patch set (#2).
Change subject: fix: macro name for Gemini Lake LPC device id ......................................................................
fix: macro name for Gemini Lake LPC device id
Change-Id: If6a22a28f2a4ca1f984b669b00bc0c07f5588328 --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c A util/inteltool/gpio_names/geminilake.h M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/pcr.c 6 files changed, 320 insertions(+), 2,443 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/40755/2
Hello build bot (Jenkins), Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40755
to look at the new patch set (#3).
Change subject: fix: macro name for Gemini Lake LPC device id ......................................................................
fix: macro name for Gemini Lake LPC device id
Change-Id: If6a22a28f2a4ca1f984b669b00bc0c07f5588328 Signed-off-by: Frieder Paape coreboot@s.paape.io --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c A util/inteltool/gpio_names/geminilake.h M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/pcr.c 6 files changed, 320 insertions(+), 2,443 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/40755/3
Frieder Paape has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40755 )
Change subject: fix: macro name for Gemini Lake LPC device id ......................................................................
Abandoned
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40755 )
Change subject: fix: macro name for Gemini Lake LPC device id ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40755/comment/50658c05_5aee4b1c PS1, Line 9: Change-Id: If6a22a28f2a4ca1f984b669b00bc0c07f5588328
Your Signed-off-by line is missing.
Done
-
Frieder Paape (Code Review) -
Name of user not set (Code Review)
-
Paul Menzel (Code Review)