coreboot@s.paape.io has uploaded this change for review.

View Change

fix: gemini lake device id is LPC

Change-Id: If6a22a28f2a4ca1f984b669b00bc0c07f5588328
---
M util/inteltool/gpio.c
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/pcr.c
4 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/40755/1
diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c
index 471485c..e11d848 100644
--- a/util/inteltool/gpio.c
+++ b/util/inteltool/gpio.c
@@ -1035,7 +1035,7 @@
case PCI_DEVICE_ID_INTEL_QM170:
case PCI_DEVICE_ID_INTEL_HM170:
case PCI_DEVICE_ID_INTEL_CM236:
- case PCI_DEVICE_ID_INTEL_GLK:
+ case PCI_DEVICE_ID_INTEL_GLK_LPC:
case PCI_DEVICE_ID_INTEL_APL_LPC:
case PCI_DEVICE_ID_INTEL_DNV_LPC:
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_PRE:
diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c
index a4bfdcb..475f701 100644
--- a/util/inteltool/inteltool.c
+++ b/util/inteltool/inteltool.c
@@ -316,7 +316,7 @@
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C224, "C224"},
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_C226, "C226"},
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_H81, "H81"},
- { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_GLK, "Gemini Lake" },
+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_GLK_LPC, "Gemini Lake" },
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_APL_LPC, "Apollo Lake" },
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_LPC, "Denverton" },
/* Intel GPUs */
diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h
index 9f5d8aa..9eff45d 100644
--- a/util/inteltool/inteltool.h
+++ b/util/inteltool/inteltool.h
@@ -267,7 +267,7 @@
#define PCI_DEVICE_ID_INTEL_BAYTRAIL_GFX 0x0f31
#define CPUID_BAYTRAIL 0x30670

-#define PCI_DEVICE_ID_INTEL_GLK 0x31e8
+#define PCI_DEVICE_ID_INTEL_GLK_LPC 0x31e8
#define PCI_DEVICE_ID_INTEL_APL_LPC 0x5ae8
#define PCI_DEVICE_ID_INTEL_DNV_LPC 0x19dc

diff --git a/util/inteltool/pcr.c b/util/inteltool/pcr.c
index 963a8b4..4733458 100644
--- a/util/inteltool/pcr.c
+++ b/util/inteltool/pcr.c
@@ -120,7 +120,7 @@
p2sb = pci_get_dev(sb->access, 0, 0, 0x1f, 1);
break;
case PCI_DEVICE_ID_INTEL_APL_LPC:
- case PCI_DEVICE_ID_INTEL_GLK:
+ case PCI_DEVICE_ID_INTEL_GLK_LPC:
p2sb = pci_get_dev(sb->access, 0, 0, 0x0d, 0);
break;
case PCI_DEVICE_ID_INTEL_H310:

To view, visit change 40755. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6a22a28f2a4ca1f984b669b00bc0c07f5588328
Gerrit-Change-Number: 40755
Gerrit-PatchSet: 1
Gerrit-Owner: coreboot@s.paape.io
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-MessageType: newchange