Attention is currently required from: Bora Guvendik, Li1 Feng, Pranava Y N, Subrata Banik, YH Lin.
Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84998?usp=email )
Change subject: mb/google/fatcat: Add ISH support with FW_CONFIG toggle
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/84998/comment/4e107271_c3eccccf?usp... :
PS3, Line 457: /* GPP_D05: NC */
: PAD_NC(GPP_D05, NONE),
: /* GPP_D06: NC */
: PAD_NC(GPP_D06, NONE),
: /* GPP_E05: NC */
: PAD_NC(GPP_E05, NONE),
Can we keep these as default case in gpio.c itself and enable ISH GPIOs when ISH is enabled?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84998?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a9734139a49be982a7dd43d5afd92e7fea6b29c
Gerrit-Change-Number: 84998
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 08 Nov 2024 06:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No