Attention is currently required from: Sathyanarayana Nujella, Anil Kumar K, Selma Bensaid.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55368 )
Change subject: mb/intel/adlrvp: Add probed fw_configs to SMBIOS OEM strings
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/intel/adlrvp/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123593):
https://review.coreboot.org/c/coreboot/+/55368/comment/41f9a7b7_0c2b8272
PS4, Line 56: }
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123593):
https://review.coreboot.org/c/coreboot/+/55368/comment/56cca60b_9c4ef5b3
PS4, Line 56: }
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05887d9d654eae6d9d2da731d8ab4cf4a05c287f
Gerrit-Change-Number: 55368
Gerrit-PatchSet: 4
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 18:38:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment