Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Subrata Banik, Patrick Rudolph, EricR Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55653 )
Change subject: soc/intel/common: Add cpu_fill_code_cache() to test eNEM ......................................................................
Patch Set 3:
(5 comments)
File src/soc/intel/common/block/cpu/cpulib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123564): https://review.coreboot.org/c/coreboot/+/55653/comment/972db12e_47a93399 PS3, Line 462: char animation[4] = {'|','/','-','\'}; space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123564): https://review.coreboot.org/c/coreboot/+/55653/comment/8f463f72_5087665c PS3, Line 462: char animation[4] = {'|','/','-','\'}; space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123564): https://review.coreboot.org/c/coreboot/+/55653/comment/aad4dc8d_27b5bf0b PS3, Line 462: char animation[4] = {'|','/','-','\'}; space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123564): https://review.coreboot.org/c/coreboot/+/55653/comment/47377c48_9feffb7d PS3, Line 493: for (int i = 0; addr < (4ULL * GiB - CONFIG_C_ENV_BOOTBLOCK_SIZE); i ++) { space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123564): https://review.coreboot.org/c/coreboot/+/55653/comment/b89407e4_0ea21179 PS3, Line 500: } void function return statements are not generally useful
-
build bot (Jenkins) (Code Review)