Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27022 )
Change subject: mb/google/poppy/variants/nocturne: config GPP_B4 for FCAM_PWR_EN
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27022/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27022/1/src/mainboard/google/poppy/variants/...
PS1, Line 180: /* D8 : ISH_I2C1_SCL ==> FCAM_PWR_EN */
: PAD_CFG_GPO(GPP_D8, 0, DEEP),
Change this to NC?
--
To view, visit
https://review.coreboot.org/27022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie875ced45dfa2aa7069851004edde8f77329df34
Gerrit-Change-Number: 27022
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Jun 2018 11:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No