HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44932 )
Change subject: mb/roda/rk9/Kconfig: Drop redundant 'select CARDBUS_PLUGIN_SUPPORT' ......................................................................
mb/roda/rk9/Kconfig: Drop redundant 'select CARDBUS_PLUGIN_SUPPORT'
CARDBUS_PLUGIN_SUPPORT is set to yes at device/Kconfig file.
Change-Id: Ief8664649c9dd58bcd1135b7251105c965c8e33e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/roda/rk9/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/44932/1
diff --git a/src/mainboard/roda/rk9/Kconfig b/src/mainboard/roda/rk9/Kconfig index f45f255..182fee4 100644 --- a/src/mainboard/roda/rk9/Kconfig +++ b/src/mainboard/roda/rk9/Kconfig @@ -10,7 +10,6 @@ select BOARD_ROMSIZE_KB_4096 select DRIVERS_GENERIC_IOAPIC select HAVE_MP_TABLE - select CARDBUS_PLUGIN_SUPPORT select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select EC_ACPI
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44932 )
Change subject: mb/roda/rk9/Kconfig: Drop redundant 'select CARDBUS_PLUGIN_SUPPORT' ......................................................................
Patch Set 1:
To be honest, I don't understand why it defaults to `y`. That this board has a Cardbus is a valuable information that I wouldn't like to drop.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44932 )
Change subject: mb/roda/rk9/Kconfig: Drop redundant 'select CARDBUS_PLUGIN_SUPPORT' ......................................................................
Abandoned