Change in coreboot[master]: mb/google/dedede: replace dt option by MSR write for disabling HWP ca...

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46459 )

Change subject: mb/google/dedede: replace dt option by MSR write for disabling HWP capability
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46459/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledee/variant.c:

https://review.coreboot.org/c/coreboot/+/46459/2/src/mainboard/google/dedede... 
PS2, Line 17: msr = rdmsr(MSR_MISC_PWR_MGMT);
            : 		msr.lo &= ~MISC_PWR_MGMT_ISST_EN;
            : 		wrmsr(MSR_MISC_PWR_MGMT, msr);
seems like this should just be put into a function in the msr block, since we've got 2 instances of the same code, and potentially more in the future. Though TBH, this doesn't make much sense as implemented, the correlation between board version and ISST enablement