Attention is currently required from: Jakub Czapiga, Julius Werner, Jérémy Compostella, Werner Zeh.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79946?usp=email )
Change subject: [RFC] region: Turn region_end() into an inclusive region_last() ......................................................................
Patch Set 6:
(3 comments)
File src/commonlib/region.c:
https://review.coreboot.org/c/coreboot/+/79946/comment/00f89643_8477c6f5 : PS5, Line 16: if (region_last(c) < region_offset(p))
Sorry, about that, I really messed up the push. It's not the final version […]
Restored the original check.
In the current version the check is partially redundant with the one in normalize_and_ok(), and shouldn't be necessary if we decide to allow only legal regions.
File src/drivers/spi/winbond.c:
https://review.coreboot.org/c/coreboot/+/79946/comment/c09640dd_9523d5d7 : PS5, Line 505: region_last(region) + 1
Yes, it would be better to use `flash->size - 1`. I guess we shouldn't […]
Done
File tests/commonlib/region-test.c:
https://review.coreboot.org/c/coreboot/+/79946/comment/f4ac3605_0d8133ff : PS5, Line 338: assert_true((uintptr_t)backing <= SIZE_MAX);
This was about asserting the unit-test was valid. I probably have seen too many […]
Done