Attention is currently required from: Tim Wawrzynczak, Robert Chen, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60331 )
Change subject: mb/google/brya/var/vell: Add AMP driver setting ......................................................................
Patch Set 8:
(8 comments)
File src/drivers/i2c/cs35l53/cs35l53.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/6759bcbb_a24e1b08 PS8, Line 72: (config->boost_peak_milliamp % 50)){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/df48ecf1_d4c505ba PS8, Line 82: acpi_dp_add_integer(dsd, "cirrus,gpio1-polarity-invert", config->gpio1_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/bebeb899_cd2762d8 PS8, Line 83: acpi_dp_add_integer(dsd, "cirrus,gpio1-output-enable", config->gpio1_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/c705cbc2_2f87a429 PS8, Line 85: acpi_dp_add_integer(dsd, "cirrus,gpio2-polarity-invert", config->gpio2_polarity_invert ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/266bd685_961f9826 PS8, Line 86: acpi_dp_add_integer(dsd, "cirrus,gpio2-output-enable", config->gpio2_output_enable ? 1 : 0); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/672efaf9_51033144 PS8, Line 108: if (config->name){ suspect code indent for conditional statements (0, 0)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/f29fe609_32d099fe PS8, Line 108: if (config->name){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137124): https://review.coreboot.org/c/coreboot/+/60331/comment/15b27cf0_44485b49 PS8, Line 108: if (config->name){ braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)