Attention is currently required from: Arec, Tim Wawrzynczak, Andy Yeh, Jim Lai, Kane Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61109 )
Change subject: mb/google/brya/var/kano: Prevent camera LED blinking during boot
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61109/comment/7f230cea_bc8641d6
PS5, Line 10: which misleads user to belive camera has been turned on.
Please remove the trailing spaces.
https://review.coreboot.org/c/coreboot/+/61109/comment/438eb1df_5e203747
PS5, Line 11: Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips
Ditto.
Please also add a blank line between paragraphs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61109
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I92f1e88d0fcce49660a95d4402c8c4161e320168
Gerrit-Change-Number: 61109
Gerrit-PatchSet: 5
Gerrit-Owner: Jim Lai
jim.lai@intel.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Arec
arec.kao@intel.com
Gerrit-Reviewer: Jim Lai
jim.lai@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Arec
arec.kao@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Andy Yeh
andy.yeh@intel.com
Gerrit-Attention: Jim Lai
jim.lai@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Wed, 19 Jan 2022 07:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment