Attention is currently required from: Furquan Shaikh, Subrata Banik, Patrick Rudolph, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51683 )
Change subject: soc/intel/alderlake: Add provision to override Rcomp settings
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51683/comment/2249c133_29b61f71
PS7, Line 14: Note: LPDDR5 is intentionally left as-is in this change because
: `ddr_config` and `lp5x_config` are members of the same union, and
: their storage space overlaps. Thus, it is not possible to use
: both of them at the same time to store settings.
Let's fix this the right way now. […]
I was thinking of making a follow-up, but I agree.
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/51683/comment/d90b8d7a_2131500d
PS7, Line 19: if (ddr_config->rcomp_resistor != 0)
`struct mem_ddr_config` is supposed to be applicable *only* for DDR4/DDR5 memories: https://review. […]
Full ack to what furquan said. I'd name the struct type `rcomp_config` to differentiate it from the `rcomp` member.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8528bbf0517728534d47f9adaabfc9a2c469609
Gerrit-Change-Number: 51683
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:52:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment