Attention is currently required from: Furquan Shaikh, Subrata Banik, Patrick Rudolph, EricR Lai.
Patch set 7:Code-Review +1
2 comments:
Commit Message:
Note: LPDDR5 is intentionally left as-is in this change because
`ddr_config` and `lp5x_config` are members of the same union, and
their storage space overlaps. Thus, it is not possible to use
both of them at the same time to store settings.
Let's fix this the right way now. […]
I was thinking of making a follow-up, but I agree.
File src/soc/intel/alderlake/meminit.c:
Patch Set #7, Line 19: if (ddr_config->rcomp_resistor != 0)
`struct mem_ddr_config` is supposed to be applicable *only* for DDR4/DDR5 memories: https://review. […]
Full ack to what furquan said. I'd name the struct type `rcomp_config` to differentiate it from the `rcomp` member.
To view, visit change 51683. To unsubscribe, or for help writing mail filters, visit settings.