Attention is currently required from: Furquan Shaikh, Angel Pons, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51683 )
Change subject: soc/intel/alderlake: Add provision to override Rcomp settings
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/51683/comment/ed8e6b66_7a7a2d47
PS7, Line 19: if (ddr_config->rcomp_resistor != 0)
`struct mem_ddr_config` is supposed to be applicable *only* for DDR4/DDR5 memories: https://review. […]
Point noted. we should do the refactor and make it ready. no question about that but it might delay the fix by another day. 😊
But at first place, i would say that, I don't really see any such documentation or claim in FSP integration guide saying "only" override rcomp resistor or target if DIMM type is DDR4/5 (please point me to such document if you have seen such) so our initial assumptions was wrong and that creates the whole confusion. Ideally we should be ready to override any and all possible board specific UPDs from bootloader side irrespective of such assumptions unless documented.
I hope you do agree with me on this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie8528bbf0517728534d47f9adaabfc9a2c469609
Gerrit-Change-Number: 51683
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 19:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment