Attention is currently required from: Furquan Shaikh, Angel Pons, Patrick Rudolph, EricR Lai.
1 comment:
File src/soc/intel/alderlake/meminit.c:
Patch Set #7, Line 19: if (ddr_config->rcomp_resistor != 0)
`struct mem_ddr_config` is supposed to be applicable *only* for DDR4/DDR5 memories: https://review. […]
Point noted. we should do the refactor and make it ready. no question about that but it might delay the fix by another day. 😊
But at first place, i would say that, I don't really see any such documentation or claim in FSP integration guide saying "only" override rcomp resistor or target if DIMM type is DDR4/5 (please point me to such document if you have seen such) so our initial assumptions was wrong and that creates the whole confusion. Ideally we should be ready to override any and all possible board specific UPDs from bootloader side irrespective of such assumptions unless documented.
I hope you do agree with me on this.
To view, visit change 51683. To unsubscribe, or for help writing mail filters, visit settings.